E.setFlags({onErrorSave:true}) now saves any uncaught errors to a file in Storage called ERROR (#2583)

            E.setFlags({onErrorFlash:true}) now flashes the red LED for 200ms on any uncaught errors

Author: gfwilliams

ChangeLog

@@ -8,8 +8,7 @@
             Add a backtrace command to debugger, add console.trace command, set Error.stack in constructor (fix #2490)
             Error.stack/stack dump now uses more standard file:line:col format
             Out of memory errors now show a backtrace (previously it was very hard to track these down)
-            Increase chars shown in strings in console to 60
-            The first Uncaught error is now saved to a file in Storage called ERROR (`E.setFlags({noErrorSave:true})` disables this) (#2583)
+            Increase chars shown in strings in console to 60            
             If debugging via bluetooth and we disconnect, quit debugging (locks Bluetooth otherwise)
             Remove Line Number handling code (most code will be run out of Storage now, where we know the line number)
             Debugger now uses jslPrintPosition to print file+line+col, is aware of Modules.addCached that IDE adds and discounts it
@@ -21,6 +20,8 @@
             E.defrag() now defrags everything, including Flat Strings (fix #1740)
             ESP32: Fix 2v26 regression which stopped many pins from being watched
             Puck.js: Revert second timer accuracy tweak that broke Puck.IR in 2v26
+            E.setFlags({onErrorSave:true}) now saves any uncaught errors to a file in Storage called ERROR (#2583)
+            E.setFlags({onErrorFlash:true}) now flashes the red LED for 200ms on any uncaught errors
 
      2v26 : nRF5x: ensure TIMER1_IRQHandler doesn't always wake idle loop up (fix #1900)
             Puck.js: On v2.1 ensure Puck.mag behaves like other variants - just returning the last reading (avoids glitches when used with Puck.magOn)

src/jsflags.h

@@ -27,11 +27,12 @@ typedef enum {
 #ifdef ESPR_JIT
   JSF_JIT_DEBUG           = 1<<4, ///< When JIT enabled, output debugging info
 #endif
-  JSF_NO_ERRORS_SAVE      = 1<<5, ///< If set, do not attempt to save errors to internal Storage
+  JSF_ON_ERROR_SAVE      = 1<<5, ///< If set, save error and stack trace to an 'ERROR' file in internal Storage
+  JSF_ON_ERROR_FLASH_LED = 1<<6, ///< If set, when we get an error, flash the Red LED
 } PACKED_FLAGS JsFlags;
 
 
-#define JSFLAG_NAMES "deepSleep\0unsafeFlash\0unsyncFiles\0pretokenise\0jitDebug\0noErrorSave\0"
+#define JSFLAG_NAMES "deepSleep\0unsafeFlash\0unsyncFiles\0pretokenise\0jitDebug\0onErrorSave\0onErrorFlash\0"
 // NOTE: \0 also added by compiler - two \0's are required!
 
 extern volatile JsFlags jsFlags;

src/jsinteractive.c

@@ -1299,8 +1299,15 @@ void jsiCheckErrors(bool wasREPL) {
     jsiConsolePrintf("Uncaught %v\n", exception);
     reportedError = true;
 #ifndef SAVE_ON_FLASH
+#ifdef LED1_PININDEX
+    if (jsfGetFlag(JSF_ON_ERROR_FLASH_LED)) {
+      Pin pin = LED1_PININDEX;
+      jshPinOutput(pin, LED1_ONSTATE);
+      jstPinOutputAtTime(jshGetTimeFromMilliseconds(200), NULL, &pin, 1, !LED1_ONSTATE);
+    }
+#endif
     JsVar *exceptionString = NULL;
-    if ((!jsfGetFlag(JSF_NO_ERRORS_SAVE)) && !jsfFindFile(jsfNameFromString("ERROR"),NULL))
+    if (jsfGetFlag(JSF_ON_ERROR_SAVE) && !jsfFindFile(jsfNameFromString("ERROR"),NULL))
       exceptionString = jsvAsString(exception);
 #endif
 

src/jswrap_espruino.c

@@ -852,9 +852,10 @@ code.
   after each command (the default is *to* flush). This is much faster, but can
   cause filesystem damage if power is lost without the filesystem unmounted.
 * `jitDebug` - When JIT compiling, outputs debug info to the console
-* `noErrorSave` - [2v27+] when an uncaught error occurs, by default it is now
-   written to a file called `ERROR` in Storage (the file is not updated). To
-   stop this happening, use `E.setFlags({noErrorSave:true})`
+* `onErrorSave` - [2v27+] when an uncaught error occurs, write it to a
+  file called `ERROR` in Storage (the file is not updated)
+* `onErrorFlash` - [2v27+] when an uncaught error occurs, flash the red LED
+  for 200ms (only on devices with a physical LED)
 */
 /*JSON{
   "type" : "staticmethod",
@@ -1671,7 +1672,7 @@ void jswrap_e_dumpVariables() {
   "name" : "defrag",
   "generate" : "jsvDefragment"
 }
-This defragment's Espruino's memory. 
+This defragment's Espruino's memory.
 
 While Espruino does a lot of work to avoid fragmentation (variables spread over memory)
 and can usually work around it (such as by allocating data in chunks) sometimes