esp32/esp108: Add "permissive mode"

Running command "esp32.cpuX set_permissive 1" will disable
memory type checks (can be extended to disable other client-side
checks in future.)

Author: projectgus

src/target/esp108.c

@@ -448,7 +448,7 @@ static int xtensa_read_memory(struct target *target,
 	int res;
 	uint8_t *albuff;
 
-	if (esp108_get_addr_type(address) == INVALID) {
+	if (esp108_get_addr_type(address) == INVALID && !esp108_permissive_mode) {
 		LOG_DEBUG("%s: address 0x%08x not readable", __func__, address);
 		return ERROR_FAIL;
 	}
@@ -522,7 +522,7 @@ static int xtensa_write_memory(struct target *target,
 	int res;
 	uint8_t *albuff;
 
-	if (esp108_get_addr_type(address) != READWRITE) {
+	if (esp108_get_addr_type(address) != READWRITE && !esp108_permissive_mode) {
 		LOG_DEBUG("%s: address 0x%08x not writable", __func__, address);
 		return ERROR_FAIL;
 	}
@@ -1449,6 +1449,8 @@ static const struct command_registration esp108_any_command_handlers[] = {
 	COMMAND_REGISTRATION_DONE
 };
 
+extern const struct command_registration esp108_common_command_handlers[];
+
 static const struct command_registration esp108_command_handlers[] = {
 	{
 		.name = "esp108",
@@ -1457,6 +1459,9 @@ static const struct command_registration esp108_command_handlers[] = {
 		.usage = "",
 		.chain = esp108_any_command_handlers,
 	},
+	{
+		.chain = esp108_common_command_handlers,
+	},
 	COMMAND_REGISTRATION_DONE
 };
 

src/target/esp108_common.c

@@ -25,6 +25,8 @@
 #include "esp108_common.h"
 #include "esp108_dbg_regs.h"
 
+bool esp108_permissive_mode;
+
 //Convert a register index that's indexed relative to windowbase, to the real address.
 enum xtensa_reg_idx windowbase_offset_to_canonical(const enum xtensa_reg_idx reg, const int windowbase)
 {
@@ -677,3 +679,30 @@ inline uint32_t intfromchars(uint8_t *c)
 {
 	return c[0] + (c[1] << 8) + (c[2] << 16) + (c[3] << 24);
 }
+
+
+COMMAND_HANDLER(handle_set_esp108_permissive_mode)
+{
+	if (CMD_ARGC != 1) {
+		return ERROR_COMMAND_SYNTAX_ERROR;
+	}
+	bool is_one = strcmp(CMD_ARGV[0], "1") == 0;
+	if (!is_one && strcmp(CMD_ARGV[0], "0") != 0) {
+		return ERROR_COMMAND_SYNTAX_ERROR; // 0 or 1 only
+	}
+	esp108_permissive_mode = is_one;
+	return ERROR_OK;
+}
+
+const struct command_registration esp108_common_command_handlers[] = {
+	{
+		.name = "set_permissive",
+		.handler = handle_set_esp108_permissive_mode,
+		.mode = COMMAND_ANY,
+		.help = "When set to 1, enable ESP108 permissive mode (less client-side checks)",
+		.usage = "[0|1]",
+	},
+	COMMAND_REGISTRATION_DONE
+};
+
+

src/target/esp108_common.h

@@ -44,6 +44,7 @@
 #include "breakpoints.h"
 #include "algorithm.h"
 
+extern bool esp108_permissive_mode;
 
 #define XT_INS_NUM_BITS 24
 #define XT_DEBUGLEVEL	 6 /* XCHAL_DEBUGLEVEL in xtensa-config.h */

src/target/esp32.c

@@ -552,7 +552,7 @@ static int xtensa_read_memory(struct target *target,
 	int res;
 	uint8_t *albuff;
 
-	if (esp108_get_addr_type(address) == INVALID) {
+	if (esp108_get_addr_type(address) == INVALID && !esp108_permissive_mode) {
 		LOG_DEBUG("%s: address 0x%08x not readable", __func__, address);
 		return ERROR_FAIL;
 	}
@@ -635,7 +635,7 @@ static int xtensa_write_memory(struct target *target,
 	int res;
 	uint8_t *albuff;
 
-	if (esp108_get_addr_type(address) != READWRITE) {
+	if (esp108_get_addr_type(address) != READWRITE && !esp108_permissive_mode) {
 		LOG_DEBUG("%s: address 0x%08x not writable", __func__, address);
 		return ERROR_FAIL;
 	}
@@ -1853,6 +1853,8 @@ static const struct command_registration esp32_any_command_handlers[] = {
 	COMMAND_REGISTRATION_DONE
 };
 
+extern const struct command_registration esp108_common_command_handlers[];
+
 static const struct command_registration esp32_command_handlers[] = {
 	{
 		.name = "esp32",
@@ -1861,6 +1863,9 @@ static const struct command_registration esp32_command_handlers[] = {
 		.usage = "",
 		.chain = esp32_any_command_handlers,
 	},
+	{
+		.chain = esp108_common_command_handlers,
+	},
 	COMMAND_REGISTRATION_DONE
 };