ci: cleanup pipeline rules

- disable allow_failure for build jobs and master tests
- retry all test jobs
- drop build dependency on style check
- set RUNNER_SCRIPT_TIMEOUT for tests

Author: sobuch

.gitlab/ci/build-test-app.yml

@@ -134,9 +134,7 @@
     - *finish_test_app_build
     - *prepare_espytrace_package
     - *prepare_sysview_config
-  dependencies: []
-  needs:
-    - job: style_check
+  needs: []
 
 .build_idf50x_test_app_template: &build_idf50x_test_app_template
   stage: build_idf5.0.x
@@ -180,7 +178,6 @@
 
 .build_idf_master_test_app_template: &build_idf_master_test_app_template
   stage: build_idf_master
-  allow_failure: true
   variables:
     TEST_APP_CONFIGS: ""
     TEST_APP_IDF_DOCKER_IMAGE: "${TEST_APP_IDF_LATEST_DOCKER_IMAGE}"
@@ -655,8 +652,7 @@ build_nuttx_app:
     project: idf/apache/esp-nuttx-apps
     strategy: depend
   allow_failure: true
-  needs:
-    - job: style_check
+  needs: []
   parallel:
     matrix:
       - TRIGGER_JOB: [openocd-esp32, openocd-esp32s2, openocd-esp32s3, openocd-esp32c3, openocd-esp32c6, openocd-esp32h2]

.gitlab/ci/build.yml

@@ -110,8 +110,7 @@
       - ${DIST_ART_DIR}
     when: always
     expire_in: 2 weeks
-  needs:
-    - job: style_check
+  needs: []
   script:
     - *get_release_name
     - export HOST_CC=${CONF_HOST}-gcc
@@ -140,8 +139,7 @@
     paths:
       - ${DIST_ART_DIR}
     expire_in: 2 weeks
-  needs:
-    - job: style_check
+  needs: []
   script:
     - *get_release_name
     - *buildx_libusb
@@ -167,8 +165,7 @@ build_linux:
     PLATFORM_NAME: "linux-amd64"
     CONF_HOST: "x86_64-linux-gnu"
     HOST_CC: ${CONF_HOST}-gcc
-  needs:
-    - job: style_check
+  needs: []
   script:
     - *get_release_name
     - apt-get update || true
@@ -192,9 +189,7 @@ build_linux_gcc_latest:
   stage: build_openocd
   tags:
     - build
-  allow_failure: true
-  needs:
-    - job: style_check
+  needs: []
   variables:
     CONF_HOST: ""
     HOST_CC: "gcc"
@@ -266,8 +261,7 @@ build_linux_arm64_test:
     CONF_HOST: "i686-w64-mingw32"
     INSTALL_TARGET: "install-strip"
     HOST_CC: ${CONF_HOST}-gcc
-  needs:
-    - job: style_check
+  needs: []
   script:
     - *get_release_name
     - *buildx_libusb
@@ -312,7 +306,6 @@ scan-build:
   stage: static_analyzers
   tags:
     - build
-  allow_failure: true
   variables:
     SCAN_BUILD_OUTPUT: "report"
     CONF_HOST: ""
@@ -342,7 +335,6 @@ sparse:
   stage: static_analyzers
   tags:
     - build
-  allow_failure: true
   variables:
     SPARSE_BUILD_OUTDIR: "sparse"
     SPARSE_BUILD_OUTFILE: "warnings.log"
@@ -373,9 +365,7 @@ build_linux_cmake:
   stage: build_openocd
   tags:
     - build
-  allow_failure: true
-  needs:
-    - job: style_check
+  needs: []
   variables:
     OPENOCD_CMAKE_CONFIGURE_OPTS: ""
   script:
@@ -390,9 +380,7 @@ build_linux_cmake:
   image: $CI_DOCKER_REGISTRY/esp32-toolchain-arm-cross:3
   tags:
     - build
-  allow_failure: true
-  needs:
-    - job: style_check
+  needs: []
   variables:
     OPENOCD_CMAKE_CONFIGURE_OPTS: ""
   script:
@@ -407,9 +395,7 @@ build_linux_cmake:
   image: $CI_DOCKER_REGISTRY/esp32-toolchain-win-cross
   tags:
     - build
-  allow_failure: true
-  needs:
-    - job: style_check
+  needs: []
   variables:
     OPENOCD_CMAKE_CONFIGURE_OPTS: ""
   script:

.gitlab/ci/test.yml

@@ -3,10 +3,10 @@
     - $CHIP_NAME
     - jtag
   variables:
+    RUNNER_SCRIPT_TIMEOUT: 60m
     PLATFORM_NAME: "linux-armhf-test"
     OOCD_CMDS: "set VAR 1" # default command to avoid missing argument error.
-    TEST_RUN_RETRY: "-r"
-    TEST_RUN_EXTRA_OPTS: "${TEST_RUN_RETRY} -i ${IDF_RELEASE_TAG} ${TEST_RUN_BOARD_OPTS} ${TEST_RUN_COMMON_ARGS}"
+    TEST_RUN_EXTRA_OPTS: "-r -i ${IDF_RELEASE_TAG} ${TEST_RUN_BOARD_OPTS} ${TEST_RUN_COMMON_ARGS}"
   artifacts:
     paths:
       - $TEST_RUN_DIR/debug_backend_tests.log
@@ -55,20 +55,14 @@
 .tests_armhf_master_template:
   extends: .tests_armhf_template
   stage: test_idf_master
-  allow_failure: true
   image: $CI_DOCKER_REGISTRY/target-test-env-v5.5:2
-  inherit:
-    default:
-      - interruptible
-      # Dont retry
   variables:
     CHIP_TEST_TOOLCHAIN: "xtensa-${CHIP_NAME}"
     ESP_GDB_TOOLCHAIN: "${ESP_V5_5X_XTENSA_GDB_TOOLCHAIN}"
     TOOLCHAIN_PREFIX: "xtensa-esp"
     ESP_TOOLCHAIN: "${ESP_V5_5X_TOOLCHAIN_VER}"
     TEST_RUN_DIR: "build_test_app_${CHIP_NAME}"
     IDF_RELEASE_TAG: "latest"
-    TEST_RUN_RETRY: "" # Dont retry
     ESP_GCOV_TOOLCHAIN: "${ESP_V5_5X_XTENSA_GCOV_TOOLCHAIN}-arm-linux-gnueabihf"
 
 .tests_arm64_master_template:
@@ -1111,10 +1105,6 @@ tests_on_linux:
   extends: .tests_armhf_v5.1.x_template
   stage: test_nuttx
   allow_failure: true
-  inherit:
-    default:
-      - interruptible
-      # Dont retry
   variables:
     RUNNER_SCRIPT_TIMEOUT: 5m
     TEST_RUN_DIR: "build_test_app_${CHIP_NAME}_nuttx_test"