Skip to content

Commit 3518f21

Browse files
committed
feat(eppp): Add simple CI check
1 parent cbde47f commit 3518f21

File tree

4 files changed

+14
-14
lines changed

4 files changed

+14
-14
lines changed

.pre-commit-config.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,8 +61,8 @@ repos:
6161
- repo: local
6262
hooks:
6363
- id: commit message scopes
64-
name: "commit message must be scoped with: mdns, modem, websocket, asio, mqtt_cxx, console, common"
65-
entry: '\A(?!(feat|fix|ci|bump|test|docs)\((mdns|modem|common|console|websocket|asio|mqtt_cxx|examples|eppp_link)\)\:)'
64+
name: "commit message must be scoped with: mdns, modem, websocket, asio, mqtt_cxx, console, common, eppp"
65+
entry: '\A(?!(feat|fix|ci|bump|test|docs)\((mdns|modem|common|console|websocket|asio|mqtt_cxx|examples|eppp)\)\:)'
6666
language: pygrep
6767
args: [--multiline]
6868
stages: [commit-msg]

components/eppp_link/.cz.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
---
22
commitizen:
3-
bump_message: 'bump(eppp_link): $current_version -> $new_version'
3+
bump_message: 'bump(eppp): $current_version -> $new_version'
44
pre_bump_hooks: python ../../ci/changelog.py eppp_link
55
tag_format: epp_link-v$version
66
version: 0.0.1

components/eppp_link/eppp_link.c

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -58,6 +58,14 @@ enum blocked_status {
5858
SLAVE_WANTS_WRITE,
5959
};
6060

61+
static void IRAM_ATTR timer_callback(void *arg)
62+
{
63+
struct eppp_handle *h = arg;
64+
if (h->blocked == SLAVE_WANTS_WRITE) {
65+
gpio_set_level(h->gpio_intr, 0);
66+
}
67+
}
68+
6169
#endif // CONFIG_EPPP_LINK_DEVICE_SPI
6270

6371
struct eppp_handle {
@@ -128,14 +136,6 @@ static esp_err_t transmit(void *h, void *buffer, size_t len)
128136
return ESP_OK;
129137
}
130138

131-
static void IRAM_ATTR timer_callback(void *arg)
132-
{
133-
struct eppp_handle *h = arg;
134-
if (h->blocked == SLAVE_WANTS_WRITE) {
135-
gpio_set_level(h->gpio_intr, 0);
136-
}
137-
}
138-
139139
static void netif_deinit(esp_netif_t *netif)
140140
{
141141
if (netif == NULL) {

components/eppp_link/test/test_app/main/app_main.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -171,7 +171,7 @@ TEST(eppp_test, open_close)
171171
TEST_ASSERT_NOT_NULL(client.netif);
172172

173173
// Now that we're connected, let's try to ping clients address
174-
bits = ping_test(config.ppp.their_ip4_addr, eppp_server, client.event);
174+
bits = ping_test(config.ppp.their_ip4_addr.addr, eppp_server, client.event);
175175
TEST_ASSERT_EQUAL(bits & (PING_SUCCEEDED | PING_FAILED), PING_SUCCEEDED);
176176

177177
// Trigger client disconnection and close the server
@@ -237,7 +237,7 @@ TEST(eppp_test, open_close_nonblocking)
237237
TEST_ASSERT_EQUAL(bits & wait_bits, wait_bits);
238238

239239
// Now that we're connected, let's try to ping clients address
240-
bits = ping_test(server_config.ppp.their_ip4_addr, eppp_server, event);
240+
bits = ping_test(server_config.ppp.their_ip4_addr.addr, eppp_server, event);
241241
TEST_ASSERT_EQUAL(bits & (PING_SUCCEEDED | PING_FAILED), PING_SUCCEEDED);
242242

243243
// stop network for both client and server
@@ -304,7 +304,7 @@ TEST(eppp_test, open_close_taskless)
304304
xEventGroupClearBits(info.event, wait_bits);
305305

306306
// Now that we're connected, let's try to ping clients address
307-
bits = ping_test(server_config.ppp.their_ip4_addr, info.eppp_server, info.event);
307+
bits = ping_test(server_config.ppp.their_ip4_addr.addr, info.eppp_server, info.event);
308308
TEST_ASSERT_EQUAL(bits & (PING_SUCCEEDED | PING_FAILED), PING_SUCCEEDED);
309309

310310
// stop network for both client and server, we won't wait for completion so expecting ESP_FAIL

0 commit comments

Comments
 (0)