-
Notifications
You must be signed in to change notification settings - Fork 7.8k
feat(gpio): Enhance GPIO validation tests with interrupt handling and… #12020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… button functionality
👋 Hello JakubAndrysek, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
Test Results 76 files 76 suites 20m 58s ⏱️ For more details on these failures, see this check. Results for commit b6e6bcb. ♻️ This comment has been updated with latest results. |
P-R-O-C-H-Y
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
lucasssvaz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description of Change
This pull request significantly expands and refactors the GPIO validation test suite. The main improvements include adding LED testing to the hardware diagrams, replacing the previous scenario-based button test with a comprehensive set of GPIO and interrupt validation tests, and updating the Python test script to coordinate detailed hardware interactions and assertions. These changes enhance the coverage and reliability of GPIO feature validation across multiple ESP32 variants.
Test coverage and scenario refactor:
scenario.yaml) is removed and replaced with a new, more granular test structure that validates both reading and writing GPIO states, as well as various interrupt behaviours.Test Scenarios
I have tested my Pull Request on Arduino-esp32 core v3.3.3 with Wokwi on all available ESP32s mentioned in the test cases.