-
-
Notifications
You must be signed in to change notification settings - Fork 2k
ssd1327: Fix datasheet link #5094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: current
Are you sure you want to change the base?
Conversation
WalkthroughThe documentation for the Changes
Possibly related PRs
Suggested reviewers
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
components/display/ssd1327.rst (1)
14-15
: Minor inconsistency: two different datasheet sources referenced
The I²C section now references Waveshare while the SPI section (line 72) still references Adafruit. Using a single canonical link (or keeping both but adding a brief note) would avoid possible confusion for readers.Also applies to: 72-73
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
components/display/ssd1327.rst
(1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**
Instructions used from:
Sources:
⚙️ CodeRabbit Configuration File
🧠 Learnings (1)
📓 Common learnings
Learnt from: jesserockz
PR: esphome/esphome-docs#4865
File: .github/workflows/needs-docs.yml:0-0
Timestamp: 2025-05-01T03:29:47.922Z
Learning: In the esphome-docs repository, the "current" label is automatically added by a bot to pull requests, making it a reliable indicator for the target branch.
🔇 Additional comments (1)
components/display/ssd1327.rst (1)
14-15
: Corrected datasheet URL looks good
The link now points to a working HTTPS source and renders the PDF without redirect issues.
✅ Deploy Preview for esphome ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Description:
Fix datasheet link for ssd1327
Checklist:
next
because this is new documentation that has a matching pull-request in esphome as linked above.or
current
because this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.