Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shorthand "-s" collision #724

Closed
georgik opened this issue Jan 15, 2025 · 3 comments · Fixed by #731
Closed

Shorthand "-s" collision #724

georgik opened this issue Jan 15, 2025 · 3 comments · Fixed by #731
Labels
bug Something isn't working CLI Issues relating to the command-line interface
Milestone
v4

Comments

@georgik
Copy link

georgik commented Jan 15, 2025

There are two usages of -s which are in the collision:

-s, --flash-size <SIZE>
-s, --skip-update-check

Workaround: use long form
@SergioGasquez SergioGasquez added this to the v4 milestone Jan 15, 2025
@SergioGasquez
Copy link
Member

This only happens for cargo-espflash, espflash has S for skip-update-check short

@georgik
Copy link
Author

georgik commented Jan 15, 2025

The output mentioned in the issue is from espflash 3.2.0

@jessebraham jessebraham added bug Something isn't working CLI Issues relating to the command-line interface labels Jan 20, 2025
@SergioGasquez SergioGasquez linked a pull request Jan 28, 2025 that will close this issue
[cargo-espflash]: Fix -s collision #731
Merged
@SergioGasquez
Copy link
Member

For espflash it was fixed in [email protected] via #705 (comment)

@github-project-automation github-project-automation bot moved this from Todo to Done in esp-rs Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working CLI Issues relating to the command-line interface
Projects
esp-rs
Archived in project
Milestone
v4
Development

Successfully merging a pull request may close this issue.

[cargo-espflash]: Fix -s collision SergioGasquez/espflash
3 participants
@georgik @jessebraham @SergioGasquez