Skip to content

CLI argument structs are not marked #[non_exhaustive] #473

Closed
@jessebraham

Description

@jessebraham

This was an incredibly unfortunately oversight which was resulted in us needing to duplicate pretty much any new options between cargo-espflash and espflash. Fixing this is a semver-incompatible change so this will need to happen as part of the v3 release, whenever that happens.

Perhaps another option would be to simply not provide semver guarantees for anything in the cli module (it is feature gated after all, and is only really useful for the binary application).

### Tasks
- [ ] `cli` module should warn that it does not provide semver guarantees

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingstatus:longtermThis task will be around a while

    Type

    No type

    Projects

    Status

    Done

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions