Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: implement fade features for ledc #518

Closed
justbuchanan opened this issue Feb 24, 2025 · 4 comments
Closed

Feature request: implement fade features for ledc #518

justbuchanan opened this issue Feb 24, 2025 · 4 comments
Labels
enhancement New feature or request

Comments

@justbuchanan
Copy link
Contributor

Hardware support for fading leds is neat and I'd like to use it in one of my projects.

If nobody is currently working on this, I can take a look at implementing it.

The fade feature in esp32 hardware is described here: https://docs.espressif.com/projects/esp-idf/en/stable/esp32/api-reference/peripherals/ledc.html#change-pwm-duty-cycle-using-hardware.

@justbuchanan justbuchanan added the enhancement New feature or request label Feb 24, 2025
@justbuchanan
Copy link
Contributor Author

cc @sirhcel since you implemented the ledc driver initially in #43. Please let me know if you have any thoughts/suggestions/advice.

@sirhcel
Copy link
Contributor

sirhcel commented Feb 25, 2025

Great to see you picking this up @justbuchanan! I have to admit that I have not looked into fading yet. You could keep me in the loop when opening a PR and I will have a look at it.

@ivmarkov
Copy link
Collaborator

Shall I close?

@justbuchanan
Copy link
Contributor Author

Yeah this can be closed now. Thanks!

@github-project-automation github-project-automation bot moved this from Todo to Done in esp-rs Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

No branches or pull requests

3 participants