Skip to content

feat: uart break send + detect #4284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 50 commits into from
Nov 10, 2025
Merged

feat: uart break send + detect #4284

merged 50 commits into from
Nov 10, 2025
+518 −1

Conversation

@zpg6
Copy link
Contributor

@zpg6 zpg6 commented Oct 8, 2025

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.
  • I have added necessary changes to user code to the latest Migration Guide.
  • My changes are in accordance to the esp-rs developer guidelines

Extra:

Pull Request Details 📖

Description

Continuation of #3177 - aiming for 1.0

Testing

Need help with HIL testing

@zpg6 zpg6 mentioned this pull request Oct 8, 2025
Closed
6 tasks
bugadani
bugadani reviewed Oct 8, 2025
View reviewed changes
bugadani
bugadani reviewed Oct 8, 2025
View reviewed changes
zpg6
zpg6 commented Oct 8, 2025
View reviewed changes
@zpg6
Copy link
Contributor Author

zpg6 commented Oct 9, 2025

@bugadani - can you tell why this isn't compiling for me?

@bugadani
Copy link
Contributor

bugadani commented Oct 9, 2025

ESP32-C2, C3 and H2 don't have GPIO16 and 17

@zpg6
Copy link
Contributor Author

zpg6 commented Oct 15, 2025

@bugadani - can you help me understand why my HIL test is failling only on esp32, esp32c6, and esp32h2? Works on others

@bugadani
Copy link
Contributor

bugadani commented Oct 17, 2025

My guess is that you need to start waiting for a break condition before you stop sending it.

@zpg6
Copy link
Contributor Author

zpg6 commented Nov 5, 2025

@bugadani - any idea why esp32 HIL hardware is failing last few builds?

 WARN probe_rs::vendor::espressif::sequences::esp32: Be careful not to reset your ESP32 while connected to the debugger! Depending on the specific device, this may render it temporarily inoperable or permanently damage it.
[2025-11-05T13:25:42Z INFO  xtask::commands::run] Running test 'alloc_psram_tlsf_quad' for 'esp32'
 WARN probe_rs::vendor::espressif::sequences::esp32: Be careful not to reset your ESP32 while connected to the debugger! Depending on the specific device, this may render it temporarily inoperable or permanently damage it.
Error: Could not determine flash size.
Caused by:
    0: An Xtensa specific error occurred.
    1: Xtensa debug module error.
    2: Error reading register 0x45
    3: Register-specific error
[2025-11-05T13:25:43Z INFO  xtask::commands::run] 'alloc_psram_tlsf_quad' done
[2025-11-05T13:25:43Z INFO  xtask::commands::run] Running test 'aes_no_psram' for 'esp32'
 WARN probe_rs::vendor::espressif::sequences::esp32: Be careful not to reset your ESP32 while connected to the debugger! Depending on the specific device, this may render it temporarily inoperable or permanently damage it.
Error: Could not determine flash size.
Caused by:
    0: An Xtensa specific error occurred.
    1: Xtensa debug module error.
    2: Error reading register 0x45
    3: Register-specific error
[2025-11-05T13:25:44Z INFO  xtask::commands::run] 'aes_no_psram' done
[2025-11-05T13:25:44Z INFO  xtask::commands::run] Running test 'esp_radio_has_wifi_ble' for 'esp32'
 WARN probe_rs::vendor::espressif::sequences::esp32: Be careful not to reset your ESP32 while connected to the debugger! Depending on the specific device, this may render it temporarily inoperable or permanently damage it.
Error: Could not determine flash size.
Caused by:
    0: An Xtensa specific error occurred.
    1: Xtensa debug module error.
    2: Error reading register 0x45
    3: Register-specific error
[2025-11-05T13:25:45Z INFO  xtask::commands::run] 'esp_radio_has_wifi_ble' done

(...and so on, all HIL tests fail only on this chip)

@bugadani
Copy link
Contributor

bugadani commented Nov 5, 2025

Don't worry about that. probe-rs can't recover the esp32 if it ends up partially flashed when a HIL run is cancelled, or sometimes when the firmware runs into some state that I don't yet know.

@zpg6 zpg6 requested a review from bugadani November 5, 2025 14:48
JurajSadel
JurajSadel reviewed Nov 10, 2025
View reviewed changes
bugadani
bugadani approved these changes Nov 10, 2025
View reviewed changes
Copy link
Contributor

@bugadani bugadani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much :)

@bugadani bugadani enabled auto-merge November 10, 2025 07:54
@bugadani bugadani added this pull request to the merge queue Nov 10, 2025
Merged via the queue into esp-rs:main with commit 7fc858d Nov 10, 2025
28 of 29 checks passed
@zpg6
Copy link
Contributor Author

zpg6 commented Nov 10, 2025

Thank you so much :)

Thank you for your help! Learned a lot :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JurajSadel JurajSadel JurajSadel left review comments

@bugadani bugadani bugadani approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zpg6 @bugadani @JurajSadel