Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider setting the MSRV toolchain in rust-toolchain.toml #86

Closed
MabezDev opened this issue Jan 30, 2025 · 4 comments
Closed

Consider setting the MSRV toolchain in rust-toolchain.toml #86

MabezDev opened this issue Jan 30, 2025 · 4 comments

Comments

@MabezDev
Copy link
Member

We could one step further in the rust-toolchain.toml by doing something like this:

[toolchain]
channel    = "stable-1.84"
components = ["rust-src"]
targets = ["riscv32imc-unknown-none-elf"]

Unfortunately I think this will only work on RISC-V until Xtensa is upstreamed.

@SergioGasquez
Copy link
Member

What is the benefit of using the MSRV version instead of the latest stable? It's to have something pinned?

@SergioGasquez SergioGasquez added this to the [email protected] milestone Jan 31, 2025
@MabezDev
Copy link
Member Author

MabezDev commented Feb 4, 2025

because stable doesn't download the latest stable toolchain, it just uses the stable toolchain installed on the system. I found this when I generated the project and my stable was too old for esp-hal.

@bjoernQ
Copy link
Collaborator

bjoernQ commented Feb 4, 2025

At least #88 would have shown you a red flag ... errr a red cross there.

The one thing I don't like about specific stables or nightlies in toolchain.toml is that I end up with a lot of them over time (probably just me especially since my SSDs have enough free space to not worry about it ...)

@MabezDev
Copy link
Member Author

MabezDev commented Feb 4, 2025

Yeah to be fair, #88 is better than this solution. Will close this.

@MabezDev MabezDev closed this as completed Feb 4, 2025
@MabezDev MabezDev closed this as not planned Won't fix, can't repro, duplicate, stale Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

3 participants