Merge pull request #3 from esign/shift-140869

jordyvanderhaegen · web-flow · commit b0593fb33635 · 2025-02-22T16:06:00.000+01:00
PHPUnit 10 Shift
diff --git a/tests/Feature/Commands/ClearTranslationsCacheCommandTest.php b/tests/Feature/Commands/ClearTranslationsCacheCommandTest.php
@@ -2,18 +2,19 @@
 
 namespace Esign\TranslationLoader\Tests\Feature\Commands;
 
+use PHPUnit\Framework\Attributes\Test;
 use Esign\TranslationLoader\Commands\ClearTranslationsCacheCommand;
 use Esign\TranslationLoader\Tests\Concerns\InteractsWithTranslator;
 use Esign\TranslationLoader\Tests\Concerns\MakesQueryCountAssertions;
 use Esign\TranslationLoader\Tests\TestCase;
 
-class ClearTranslationsCacheCommandTest extends TestCase
+final class ClearTranslationsCacheCommandTest extends TestCase
 {
     use InteractsWithTranslator;
     use MakesQueryCountAssertions;
 
-    /** @test */
-    public function it_can_clear_the_translations_cache()
+    #[Test]
+    public function it_can_clear_the_translations_cache(): void
     {
         // Request the translation so the database translations get queried and cached.
         // This causes the first database query.
diff --git a/tests/Feature/Commands/ImportFileTranslationToDatabaseCommandTest.php b/tests/Feature/Commands/ImportFileTranslationToDatabaseCommandTest.php
@@ -2,14 +2,15 @@
 
 namespace Esign\TranslationLoader\Tests\Feature\Commands;
 
+use PHPUnit\Framework\Attributes\Test;
 use Esign\TranslationLoader\Commands\ImportFileTranslationsToDatabaseCommand;
 use Esign\TranslationLoader\Models\Translation;
 use Esign\TranslationLoader\Tests\TestCase;
 
-class ImportFileTranslationToDatabaseCommandTest extends TestCase
+final class ImportFileTranslationToDatabaseCommandTest extends TestCase
 {
-    /** @test */
-    public function it_can_import_translations()
+    #[Test]
+    public function it_can_import_translations(): void
     {
         $this->artisan(ImportFileTranslationsToDatabaseCommand::class, ['--locales' => 'en,nl']);
 
@@ -21,8 +22,8 @@ public function it_can_import_translations()
         ]);
     }
 
-    /** @test */
-    public function it_can_import_translations_for_specific_locales()
+    #[Test]
+    public function it_can_import_translations_for_specific_locales(): void
     {
         $this->artisan(ImportFileTranslationsToDatabaseCommand::class, ['--locales' => 'en']);
 
@@ -34,8 +35,8 @@ public function it_can_import_translations_for_specific_locales()
         ]);
     }
 
-    /** @test */
-    public function it_wont_overwrite_existing_translations_when_the_overwrite_flag_was_not_given()
+    #[Test]
+    public function it_wont_overwrite_existing_translations_when_the_overwrite_flag_was_not_given(): void
     {
         Translation::create([
             'group' => '*',
@@ -54,8 +55,8 @@ public function it_wont_overwrite_existing_translations_when_the_overwrite_flag_
         ]);
     }
 
-    /** @test */
-    public function it_can_overwrite_existing_translations()
+    #[Test]
+    public function it_can_overwrite_existing_translations(): void
     {
         Translation::create([
             'group' => '*',
@@ -74,8 +75,8 @@ public function it_can_overwrite_existing_translations()
         ]);
     }
 
-    /** @test */
-    public function it_wont_overwrite_existing_translations_for_locales_that_were_not_specified()
+    #[Test]
+    public function it_wont_overwrite_existing_translations_for_locales_that_were_not_specified(): void
     {
         Translation::create([
             'group' => '*',
@@ -94,17 +95,17 @@ public function it_wont_overwrite_existing_translations_for_locales_that_were_no
         ]);
     }
 
-    /** @test */
-    public function it_can_report_the_affected_records()
+    #[Test]
+    public function it_can_report_the_affected_records(): void
     {
         $command = $this->artisan(ImportFileTranslationsToDatabaseCommand::class, ['--locales' => 'en']);
 
         $command->expectsOutputToContain('Successfully imported translations, affected records: 1.');
         $command->assertSuccessful();
     }
 
-    /** @test */
-    public function it_can_report_the_affected_records_when_a_translation_is_already_present()
+    #[Test]
+    public function it_can_report_the_affected_records_when_a_translation_is_already_present(): void
     {
         Translation::create([
             'group' => '*',
@@ -118,17 +119,17 @@ public function it_can_report_the_affected_records_when_a_translation_is_already
         $command->assertSuccessful();
     }
 
-    /** @test */
-    public function it_can_report_affected_records_when_the_overwrite_flag_is_given()
+    #[Test]
+    public function it_can_report_affected_records_when_the_overwrite_flag_is_given(): void
     {
         $command = $this->artisan(ImportFileTranslationsToDatabaseCommand::class, ['--locales' => 'en', '--overwrite' => true]);
 
         $command->expectsOutputToContain('Successfully imported translations, affected records: 1.');
         $command->assertSuccessful();
     }
 
-    /** @test */
-    public function it_can_report_affected_records_when_the_overwrite_flag_is_given_and_a_translation_is_already_present()
+    #[Test]
+    public function it_can_report_affected_records_when_the_overwrite_flag_is_given_and_a_translation_is_already_present(): void
     {
         Translation::create([
             'group' => '*',
diff --git a/tests/Feature/CustomAggregateLoaderTest.php b/tests/Feature/CustomAggregateLoaderTest.php
@@ -2,14 +2,15 @@
 
 namespace Esign\TranslationLoader\Tests\Feature;
 
+use PHPUnit\Framework\Attributes\Test;
 use Esign\TranslationLoader\Tests\Loaders\CustomAggregateLoader;
 use Esign\TranslationLoader\Tests\TestCase;
 use Illuminate\Support\Facades\Config;
 
-class CustomAggregateLoaderTest extends TestCase
+final class CustomAggregateLoaderTest extends TestCase
 {
-    /** @test */
-    public function it_can_use_a_custom_aggregate_loader()
+    #[Test]
+    public function it_can_use_a_custom_aggregate_loader(): void
     {
         Config::set('translation-loader.aggregate_loader', CustomAggregateLoader::class);
 
diff --git a/tests/Feature/CustomTranslationModelTest.php b/tests/Feature/CustomTranslationModelTest.php
@@ -2,17 +2,18 @@
 
 namespace Esign\TranslationLoader\Tests\Feature;
 
+use PHPUnit\Framework\Attributes\Test;
 use Esign\TranslationLoader\Exceptions\InvalidConfiguration;
 use Esign\TranslationLoader\Tests\Models\CustomTranslationModel;
 use Esign\TranslationLoader\Tests\Models\InvalidTranslationModel;
 use Esign\TranslationLoader\Tests\TestCase;
 use Esign\TranslationLoader\TranslationLoaderServiceProvider;
 use Illuminate\Support\Facades\Config;
 
-class CustomTranslationModelTest extends TestCase
+final class CustomTranslationModelTest extends TestCase
 {
-    /** @test */
-    public function it_can_use_a_custom_model_to_load_database_translations()
+    #[Test]
+    public function it_can_use_a_custom_model_to_load_database_translations(): void
     {
         Config::set('translation-loader.model', CustomTranslationModel::class);
         CustomTranslationModel::create([
@@ -24,8 +25,8 @@ public function it_can_use_a_custom_model_to_load_database_translations()
         $this->assertEquals('test en', trans('database.key'));
     }
 
-    /** @test */
-    public function it_will_throw_an_exception_when_the_model_does_not_implement_the_redirect_contract()
+    #[Test]
+    public function it_will_throw_an_exception_when_the_model_does_not_implement_the_redirect_contract(): void
     {
         Config::set('translation-loader.model', InvalidTranslationModel::class);
         $this->expectException(InvalidConfiguration::class);
diff --git a/tests/Feature/TranslationLoaderServiceProviderTest.php b/tests/Feature/TranslationLoaderServiceProviderTest.php
@@ -2,20 +2,21 @@
 
 namespace Esign\TranslationLoader\Tests\Feature;
 
+use PHPUnit\Framework\Attributes\Test;
 use Esign\TranslationLoader\Loaders\AggregateLoader;
 use Esign\TranslationLoader\Tests\TestCase;
 use Esign\TranslationLoader\Translator;
 
-class TranslationLoaderServiceProviderTest extends TestCase
+final class TranslationLoaderServiceProviderTest extends TestCase
 {
-    /** @test */
-    public function it_can_override_the_translator_binding_in_the_container()
+    #[Test]
+    public function it_can_override_the_translator_binding_in_the_container(): void
     {
         $this->assertInstanceOf(Translator::class, $this->app->make('translator'));
     }
 
-    /** @test */
-    public function it_can_override_the_translation_loader_biding_in_the_container()
+    #[Test]
+    public function it_can_override_the_translation_loader_biding_in_the_container(): void
     {
         $this->assertInstanceOf(AggregateLoader::class, $this->app->make('translation.loader'));
     }
diff --git a/tests/Feature/TranslationTest.php b/tests/Feature/TranslationTest.php
diff --git a/tests/Feature/TranslationsCacheTest.php b/tests/Feature/TranslationsCacheTest.php

Original file line number	Diff line number	Diff line change
`@@ -2,14 +2,15 @@`
`2`	`2`
`3`	`3`	`namespace Esign\TranslationLoader\Tests\Feature\Commands;`
`4`	`4`
	`5`	`+use PHPUnit\Framework\Attributes\Test;`
`5`	`6`	`use Esign\TranslationLoader\Commands\ImportFileTranslationsToDatabaseCommand;`
`6`	`7`	`use Esign\TranslationLoader\Models\Translation;`
`7`	`8`	`use Esign\TranslationLoader\Tests\TestCase;`
`8`	`9`
`9`		`-class ImportFileTranslationToDatabaseCommandTest extends TestCase`
	`10`	`+final class ImportFileTranslationToDatabaseCommandTest extends TestCase`
`10`	`11`	`{`
`11`		`- /** @test */`
`12`		`- public function it_can_import_translations()`
	`12`	`+ #[Test]`
	`13`	`+ public function it_can_import_translations(): void`
`13`	`14`	`{`
`14`	`15`	`$this->artisan(ImportFileTranslationsToDatabaseCommand::class, ['--locales' => 'en,nl']);`
`15`	`16`
`@@ -21,8 +22,8 @@ public function it_can_import_translations()`
`21`	`22`	`]);`
`22`	`23`	`}`
`23`	`24`
`24`		`- /** @test */`
`25`		`- public function it_can_import_translations_for_specific_locales()`
	`25`	`+ #[Test]`
	`26`	`+ public function it_can_import_translations_for_specific_locales(): void`
`26`	`27`	`{`
`27`	`28`	`$this->artisan(ImportFileTranslationsToDatabaseCommand::class, ['--locales' => 'en']);`
`28`	`29`
`@@ -34,8 +35,8 @@ public function it_can_import_translations_for_specific_locales()`
`34`	`35`	`]);`
`35`	`36`	`}`
`36`	`37`
`37`		`- /** @test */`
`38`		`- public function it_wont_overwrite_existing_translations_when_the_overwrite_flag_was_not_given()`
	`38`	`+ #[Test]`
	`39`	`+ public function it_wont_overwrite_existing_translations_when_the_overwrite_flag_was_not_given(): void`
`39`	`40`	`{`
`40`	`41`	`Translation::create([`
`41`	`42`	`'group' => '*',`
`@@ -54,8 +55,8 @@ public function it_wont_overwrite_existing_translations_when_the_overwrite_flag_`
`54`	`55`	`]);`
`55`	`56`	`}`
`56`	`57`
`57`		`- /** @test */`
`58`		`- public function it_can_overwrite_existing_translations()`
	`58`	`+ #[Test]`
	`59`	`+ public function it_can_overwrite_existing_translations(): void`
`59`	`60`	`{`
`60`	`61`	`Translation::create([`
`61`	`62`	`'group' => '*',`
`@@ -74,8 +75,8 @@ public function it_can_overwrite_existing_translations()`
`74`	`75`	`]);`
`75`	`76`	`}`
`76`	`77`
`77`		`- /** @test */`
`78`		`- public function it_wont_overwrite_existing_translations_for_locales_that_were_not_specified()`
	`78`	`+ #[Test]`
	`79`	`+ public function it_wont_overwrite_existing_translations_for_locales_that_were_not_specified(): void`
`79`	`80`	`{`
`80`	`81`	`Translation::create([`
`81`	`82`	`'group' => '*',`
`@@ -94,17 +95,17 @@ public function it_wont_overwrite_existing_translations_for_locales_that_were_no`
`94`	`95`	`]);`
`95`	`96`	`}`
`96`	`97`
`97`		`- /** @test */`
`98`		`- public function it_can_report_the_affected_records()`
	`98`	`+ #[Test]`
	`99`	`+ public function it_can_report_the_affected_records(): void`
`99`	`100`	`{`
`100`	`101`	`$command = $this->artisan(ImportFileTranslationsToDatabaseCommand::class, ['--locales' => 'en']);`
`101`	`102`
`102`	`103`	`$command->expectsOutputToContain('Successfully imported translations, affected records: 1.');`
`103`	`104`	`$command->assertSuccessful();`
`104`	`105`	`}`
`105`	`106`
`106`		`- /** @test */`
`107`		`- public function it_can_report_the_affected_records_when_a_translation_is_already_present()`
	`107`	`+ #[Test]`
	`108`	`+ public function it_can_report_the_affected_records_when_a_translation_is_already_present(): void`
`108`	`109`	`{`
`109`	`110`	`Translation::create([`
`110`	`111`	`'group' => '*',`
`@@ -118,17 +119,17 @@ public function it_can_report_the_affected_records_when_a_translation_is_already`
`118`	`119`	`$command->assertSuccessful();`
`119`	`120`	`}`
`120`	`121`
`121`		`- /** @test */`
`122`		`- public function it_can_report_affected_records_when_the_overwrite_flag_is_given()`
	`122`	`+ #[Test]`
	`123`	`+ public function it_can_report_affected_records_when_the_overwrite_flag_is_given(): void`
`123`	`124`	`{`
`124`	`125`	`$command = $this->artisan(ImportFileTranslationsToDatabaseCommand::class, ['--locales' => 'en', '--overwrite' => true]);`
`125`	`126`
`126`	`127`	`$command->expectsOutputToContain('Successfully imported translations, affected records: 1.');`
`127`	`128`	`$command->assertSuccessful();`
`128`	`129`	`}`
`129`	`130`
`130`		`- /** @test */`
`131`		`- public function it_can_report_affected_records_when_the_overwrite_flag_is_given_and_a_translation_is_already_present()`
	`131`	`+ #[Test]`
	`132`	`+ public function it_can_report_affected_records_when_the_overwrite_flag_is_given_and_a_translation_is_already_present(): void`
`132`	`133`	`{`
`133`	`134`	`Translation::create([`
`134`	`135`	`'group' => '*',`
Original file line number	Diff line number	Diff line change
`@@ -2,20 +2,21 @@`
`2`	`2`
`3`	`3`	`namespace Esign\TranslationLoader\Tests\Feature;`
`4`	`4`
	`5`	`+use PHPUnit\Framework\Attributes\Test;`
`5`	`6`	`use Esign\TranslationLoader\Loaders\AggregateLoader;`
`6`	`7`	`use Esign\TranslationLoader\Tests\TestCase;`
`7`	`8`	`use Esign\TranslationLoader\Translator;`
`8`	`9`
`9`		`-class TranslationLoaderServiceProviderTest extends TestCase`
	`10`	`+final class TranslationLoaderServiceProviderTest extends TestCase`
`10`	`11`	`{`
`11`		`- /** @test */`
`12`		`- public function it_can_override_the_translator_binding_in_the_container()`
	`12`	`+ #[Test]`
	`13`	`+ public function it_can_override_the_translator_binding_in_the_container(): void`
`13`	`14`	`{`
`14`	`15`	`$this->assertInstanceOf(Translator::class, $this->app->make('translator'));`
`15`	`16`	`}`
`16`	`17`
`17`		`- /** @test */`
`18`		`- public function it_can_override_the_translation_loader_biding_in_the_container()`
	`18`	`+ #[Test]`
	`19`	`+ public function it_can_override_the_translation_loader_biding_in_the_container(): void`
`19`	`20`	`{`
`20`	`21`	`$this->assertInstanceOf(AggregateLoader::class, $this->app->make('translation.loader'));`
`21`	`22`	`}`