rpc: investigate refund option

Author: chfast

silkworm/core/execution/processor.cpp

@@ -261,6 +261,8 @@ void ExecutionProcessor::execute_transaction(const Transaction& txn, Receipt& re
 }
 
 CallResult ExecutionProcessor::call(const Transaction& txn, const std::vector<std::shared_ptr<EvmTracer>>& tracers, bool refund) noexcept {
+    SILKWORM_ASSERT(refund);
+    (void)refund;
     const std::optional<evmc::address> sender{txn.sender()};
     SILKWORM_ASSERT(sender);
 
@@ -306,6 +308,8 @@ CallResult ExecutionProcessor::call(const Transaction& txn, const std::vector<st
     if (refund && !evm().bailout) {
         gas_used = txn.gas_limit - refund_gas(txn, effective_gas_price, result.gas_left, result.gas_refund);
         gas_left = txn.gas_limit - gas_used;
+    } else {
+        SILKWORM_ASSERT(bailout);
     }
 
     // Reward the fee recipient

silkworm/rpc/core/evm_executor_test.cpp

@@ -150,7 +150,7 @@ TEST_CASE_METHOD(EVMExecutorTest, "EVMExecutor") {
         txn.set_sender(0xa872626373628737383927236382161739290870_address);
 
         EVMExecutor executor{block, *chain_config_ptr, workers, state};
-        const auto result = executor.call(txn, {}, false, /* gasBailout */ true);
+        const auto result = executor.call(txn, {}, true, /* gasBailout */ true);
         executor.reset();
         CHECK(result.status_code == evmc_status_code::EVMC_SUCCESS);
     }