You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The question is, should eps be default or an argument to mrf_penalty.phylo() and should be this implemented for other methods? Or is this too finicky, in which case maybe there should be a .matrix method that takes a covariance matrix so people can provide it themselves as needed?
Happy to PR if we agree on the best way to do this.
The text was updated successfully, but these errors were encountered:
When fitting a funky phylogeny, I got the following error:
This can be solved by modifying the variance-covariance matrix slightly, making https://github.com/eric-pedersen/MRFtools/blob/master/R/penalties.R#L222 into:
The question is, should
eps
be default or an argument tomrf_penalty.phylo()
and should be this implemented for other methods? Or is this too finicky, in which case maybe there should be a.matrix
method that takes a covariance matrix so people can provide it themselves as needed?Happy to PR if we agree on the best way to do this.
The text was updated successfully, but these errors were encountered: