-
Notifications
You must be signed in to change notification settings - Fork 51
Labels
good first issueGood for newcomersGood for newcomers
Description
TransactionHintsBag splits hints into secret (OwnCommitment) and public hints, but this isn't done correctly. Instead TransactionHintsBag.public_hints contains all CommitmentHints (including OwnCommitment) and .secret_hints contains SecretProven.
In ergo-lib-python there is also a without_secrets function in HintsBag that removes OwnCommitment which is suitable for sharing with other signers. Consider adding this to the other bindings and native library to prevent API misuse (signers accidentally sharing private randomness leading to private key leakage if they're not careful)
Correct implementation:
Metadata
Metadata
Assignees
Labels
good first issueGood for newcomersGood for newcomers