Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unnecessary numerics when handling two or more unknown modes #2213

Open
slingamn opened this issue Feb 4, 2025 · 0 comments
Open

unnecessary numerics when handling two or more unknown modes #2213

slingamn opened this issue Feb 4, 2025 · 0 comments
Labels
bug
Milestone
v2.16

Comments

@slingamn
Copy link
Member

slingamn commented Feb 4, 2025 

>>> MODE #ccc +XY
:testnet.ergo.chat 472 ccc X :is an unknown mode character to me
:testnet.ergo.chat 472 ccc Y :is an unknown mode character to me
:testnet.ergo.chat 324 ccc #ccc +nt
:testnet.ergo.chat 329 ccc #ccc 1738636568

324 and 329 are unnecessary here, the condition is just slightly wrong.
@slingamn slingamn added the bug label Feb 4, 2025
@slingamn slingamn modified the milestones: v2.15, v2.16 Feb 4, 2025
slingamn added a commit to slingamn/ergo that referenced this issue Feb 4, 2025
@slingamn
fix ergochat#2213
8fa6e19 
We intended to suppress 324 and 329 when there is no valid mode change, only
unknown modes. Fix these checks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v2.16
Development

No branches or pull requests
1 participant
@slingamn