From 8fa6e19c2e15df7da84cb2bdde2487608cf0a274 Mon Sep 17 00:00:00 2001 From: Shivaram Lingamneni Date: Mon, 3 Feb 2025 21:33:50 -0500 Subject: [PATCH] fix #2213 We intended to suppress 324 and 329 when there is no valid mode change, only unknown modes. Fix these checks. --- irc/handlers.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/irc/handlers.go b/irc/handlers.go index 296a518b..3dd6ba40 100644 --- a/irc/handlers.go +++ b/irc/handlers.go @@ -1859,7 +1859,7 @@ func cmodeHandler(server *Server, client *Client, msg ircmsg.Message, rb *Respon for _, char := range unknown { rb.Add(nil, server.name, ERR_UNKNOWNMODE, client.nick, string(char), client.t("is an unknown mode character to me")) } - if len(unknown) == 1 && len(changes) == 0 { + if len(unknown) != 0 && len(changes) == 0 { return false } } @@ -1946,7 +1946,7 @@ func umodeHandler(server *Server, client *Client, msg ircmsg.Message, rb *Respon for _, char := range unknown { rb.Add(nil, server.name, ERR_UNKNOWNMODE, cDetails.nick, string(char), client.t("is an unknown mode character to me")) } - if len(unknown) == 1 && len(changes) == 0 { + if len(unknown) != 0 && len(changes) == 0 { return false }