You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
However, it is problem-pone if the _target is set to a wrong address: nothing will happen after the unexpected call. Should the interface revert if data is not empty and target is not a contract?
The text was updated successfully, but these errors were encountered:
If the target is invalid, the result won't be a success and the function will revert.
BTW, target cannot be limited to contracts, if not you won't be able to transfer any asset to your EOA wallet, etc.
Also, data must contain something, if not there is nothing to execute. The contract may validate the data, but that would be very expensive on gas.
If the target is invalid, the result won't be a success and the function will revert. BTW, target cannot be limited to contracts, if not you won't be able to transfer any asset to your EOA wallet, etc. Also, data must contain something, if not there is nothing to execute. The contract may validate the data, but that would be very expensive on gas.
I created this issue for the reason that I mischoose the _target parameter: I wanted to initiate an ERC20 transfer from the TBA to an EOA, but use the EOA address as the _target rather than the ERC20 contract. I constructed and send the transaction, and nothing happens, and I thought it was a success. However, you would know that the situation is quite opposite. And somewhat you yourself even made similar mistake as me: BTW, target cannot be limited to contracts, if not you won't be able to transfer any asset to your EOA wallet, etc. It was true if the asset refers to ETH, but never ERC20/721 or other innative assets
Currently, the reference implementation will execute call regardless of target
However, it is problem-pone if the _target is set to a wrong address: nothing will happen after the unexpected call. Should the interface revert if data is not empty and target is not a contract?
The text was updated successfully, but these errors were encountered: