Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make EverestConfig immutable #9788

Open
oyvindeide opened this issue Jan 17, 2025 · 0 comments · May be fixed by #9842
Open

Make EverestConfig immutable #9788

oyvindeide opened this issue Jan 17, 2025 · 0 comments · May be fixed by #9842
Assignees

Comments

@oyvindeide
Copy link
Collaborator

Came across this comment:

# Makes property.setter work
# Based on https://github.com/pydantic/pydantic/issues/1577#issuecomment-790506164
# We should use computed_property instead of this, when upgrading to pydantic 2.
class BaseModelWithPropertySupport(BaseModel):
, which might not be relevant any more. We did some work on make the everest config immutable, and if it is not fully immutable, we should make it immutable and remove property support.

@oyvindeide oyvindeide moved this to Todo in SCOUT Jan 17, 2025
@DanSava DanSava self-assigned this Jan 20, 2025
@DanSava DanSava moved this from Todo to In Progress in SCOUT Jan 20, 2025
@DanSava DanSava moved this from In Progress to Ready for Review in SCOUT Jan 20, 2025
@oyvindeide oyvindeide moved this from Ready for Review to Reviewed in SCOUT Jan 20, 2025
@oyvindeide oyvindeide moved this from Reviewed to Ready for Review in SCOUT Jan 20, 2025
@oyvindeide oyvindeide moved this from Ready for Review to Reviewed in SCOUT Jan 20, 2025
@DanSava DanSava moved this from Reviewed to In Progress in SCOUT Jan 21, 2025
@DanSava DanSava linked a pull request Jan 22, 2025 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

2 participants