Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review: tests/everest/test_samplers.py::test_sampler_uniform #9730

Closed
oyvindeide opened this issue Jan 14, 2025 · 2 comments · Fixed by #9904
Closed

Review: tests/everest/test_samplers.py::test_sampler_uniform #9730

oyvindeide opened this issue Jan 14, 2025 · 2 comments · Fixed by #9904
Assignees

Comments

@oyvindeide
Copy link
Collaborator

This test takes a long time to run, we should see if there is a way we can improve the runtime without compromising the quality of what is being tested.

@oyvindeide oyvindeide added this to SCOUT Jan 14, 2025
@oyvindeide oyvindeide moved this to Todo in SCOUT Jan 14, 2025
@frode-aarstad frode-aarstad moved this from Todo to In Progress in SCOUT Jan 29, 2025
@frode-aarstad frode-aarstad self-assigned this Jan 29, 2025
@frode-aarstad
Copy link
Contributor

frode-aarstad commented Jan 29, 2025

Dont think its possible to speed up this. Cant use cache or reduce batch size from my limited knowledge of everest workings.

Perhaps reviewer can have a look or close the issue

@frode-aarstad frode-aarstad moved this from In Progress to Ready for Review in SCOUT Jan 29, 2025
@verveerpj
Copy link
Contributor

I thinks those tests are unnecessary. They test if the samplers work, but that is tested anyway in ropt, it should not be the responsibility of Everest. The handling of samplers in everest2ropt is already tested, so that is fine.

Maybe you can just remove these tests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants