fixup! Validate workflow job args against hook runtime fixtures

address review

Author: yngve-sk

tests/ert/unit_tests/config/test_ert_config.py

@@ -1995,8 +1995,9 @@ def run(self, *args):
     assert ert_config.substitutions["<FOO2>"] == "ertconfig_foo2"
 
 
+@pytest.fixture
 @pytest.mark.usefixtures("use_tmpdir")
-def test_ert_script_hook_pre_experiment_but_asks_for_storage():
+def set_me_up():
     workflow_file_path = os.path.join(os.getcwd(), "workflow")
     with open(workflow_file_path, mode="w", encoding="utf-8") as fh:
         fh.write("TEST_SCRIPT")
@@ -2005,14 +2006,16 @@ def test_ert_script_hook_pre_experiment_but_asks_for_storage():
         fh.write(
             dedent(
                 f"""
-                NUM_REALIZATIONS 1
+                    NUM_REALIZATIONS 1
 
-                LOAD_WORKFLOW {workflow_file_path} workflow_alias
-                HOOK_WORKFLOW workflow_alias PRE_EXPERIMENT
-                """
+                    LOAD_WORKFLOW {workflow_file_path} workflow_alias
+                    HOOK_WORKFLOW workflow_alias PRE_EXPERIMENT
+                    """
             )
         )
 
+
+def test_ert_script_hook_pre_experiment_but_asks_for_storage(set_me_up):
     class SomeScript(ErtScript):
         def run(self, storage: Storage):
             pass
@@ -2032,23 +2035,7 @@ def run(self, storage: Storage):
 
 
 @pytest.mark.usefixtures("use_tmpdir")
-def test_ert_script_hook_pre_experiment_but_asks_for_ensemble():
-    workflow_file_path = os.path.join(os.getcwd(), "workflow")
-    with open(workflow_file_path, mode="w", encoding="utf-8") as fh:
-        fh.write("TEST_SCRIPT")
-
-    with open("config.ert", mode="w", encoding="utf-8") as fh:
-        fh.write(
-            dedent(
-                f"""
-                NUM_REALIZATIONS 1
-
-                LOAD_WORKFLOW {workflow_file_path} workflow_alias
-                HOOK_WORKFLOW workflow_alias PRE_EXPERIMENT
-                """
-            )
-        )
-
+def test_ert_script_hook_pre_experiment_but_asks_for_ensemble(set_me_up):
     class SomeScript(ErtScript):
         def run(self, ensemble: LocalEnsemble):
             pass
@@ -2068,23 +2055,7 @@ def run(self, ensemble: LocalEnsemble):
 
 
 @pytest.mark.usefixtures("use_tmpdir")
-def test_ert_script_hook_pre_experiment_but_asks_for_random_seed():
-    workflow_file_path = os.path.join(os.getcwd(), "workflow")
-    with open(workflow_file_path, mode="w", encoding="utf-8") as fh:
-        fh.write("TEST_SCRIPT")
-
-    with open("config.ert", mode="w", encoding="utf-8") as fh:
-        fh.write(
-            dedent(
-                f"""
-                NUM_REALIZATIONS 1
-
-                LOAD_WORKFLOW {workflow_file_path} workflow_alias
-                HOOK_WORKFLOW workflow_alias PRE_EXPERIMENT
-                """
-            )
-        )
-
+def test_ert_script_hook_pre_experiment_but_asks_for_random_seed(set_me_up):
     class SomeScript(ErtScript):
         def run(self, random_seed: int):
             pass
@@ -2099,23 +2070,7 @@ def run(self, random_seed: int):
 
 
 @pytest.mark.usefixtures("use_tmpdir")
-def test_ert_script_hook_pre_experiment_essettings_fails():
-    workflow_file_path = os.path.join(os.getcwd(), "workflow")
-    with open(workflow_file_path, mode="w", encoding="utf-8") as fh:
-        fh.write("TEST_SCRIPT")
-
-    with open("config.ert", mode="w", encoding="utf-8") as fh:
-        fh.write(
-            dedent(
-                f"""
-                NUM_REALIZATIONS 1
-
-                LOAD_WORKFLOW {workflow_file_path} workflow_alias
-                HOOK_WORKFLOW workflow_alias PRE_EXPERIMENT
-                """
-            )
-        )
-
+def test_ert_script_hook_pre_experiment_essettings_fails(set_me_up):
     class SomeScript(ErtScript):
         def run(self, es_settings: ESSettings):
             pass