fixup! Validate workflow job args against hook runtime fixtures

address review

Author: yngve-sk

tests/ert/unit_tests/config/test_ert_config.py

@@ -1995,8 +1995,8 @@ def run(self, *args):
     assert ert_config.substitutions["<FOO2>"] == "ertconfig_foo2"
 
 
-@pytest.mark.usefixtures("use_tmpdir")
-def test_ert_script_hook_pre_experiment_but_asks_for_storage():
+@pytest.fixture
+def setup_workflow_file():
     workflow_file_path = os.path.join(os.getcwd(), "workflow")
     with open(workflow_file_path, mode="w", encoding="utf-8") as fh:
         fh.write("TEST_SCRIPT")
@@ -2005,14 +2005,17 @@ def test_ert_script_hook_pre_experiment_but_asks_for_storage():
         fh.write(
             dedent(
                 f"""
-                NUM_REALIZATIONS 1
+                    NUM_REALIZATIONS 1
 
-                LOAD_WORKFLOW {workflow_file_path} workflow_alias
-                HOOK_WORKFLOW workflow_alias PRE_EXPERIMENT
-                """
+                    LOAD_WORKFLOW {workflow_file_path} workflow_alias
+                    HOOK_WORKFLOW workflow_alias PRE_EXPERIMENT
+                    """
             )
         )
 
+
+@pytest.mark.usefixtures("use_tmpdir", "setup_workflow_file")
+def test_ert_script_hook_pre_experiment_but_asks_for_storage():
     class SomeScript(ErtScript):
         def run(self, storage: Storage):
             pass
@@ -2031,24 +2034,8 @@ def run(self, storage: Storage):
         ErtConfig.from_file("config.ert")
 
 
-@pytest.mark.usefixtures("use_tmpdir")
+@pytest.mark.usefixtures("use_tmpdir", "setup_workflow_file")
 def test_ert_script_hook_pre_experiment_but_asks_for_ensemble():
-    workflow_file_path = os.path.join(os.getcwd(), "workflow")
-    with open(workflow_file_path, mode="w", encoding="utf-8") as fh:
-        fh.write("TEST_SCRIPT")
-
-    with open("config.ert", mode="w", encoding="utf-8") as fh:
-        fh.write(
-            dedent(
-                f"""
-                NUM_REALIZATIONS 1
-
-                LOAD_WORKFLOW {workflow_file_path} workflow_alias
-                HOOK_WORKFLOW workflow_alias PRE_EXPERIMENT
-                """
-            )
-        )
-
     class SomeScript(ErtScript):
         def run(self, ensemble: LocalEnsemble):
             pass
@@ -2067,24 +2054,8 @@ def run(self, ensemble: LocalEnsemble):
         ErtConfig.from_file("config.ert")
 
 
-@pytest.mark.usefixtures("use_tmpdir")
+@pytest.mark.usefixtures("use_tmpdir", "setup_workflow_file")
 def test_ert_script_hook_pre_experiment_but_asks_for_random_seed():
-    workflow_file_path = os.path.join(os.getcwd(), "workflow")
-    with open(workflow_file_path, mode="w", encoding="utf-8") as fh:
-        fh.write("TEST_SCRIPT")
-
-    with open("config.ert", mode="w", encoding="utf-8") as fh:
-        fh.write(
-            dedent(
-                f"""
-                NUM_REALIZATIONS 1
-
-                LOAD_WORKFLOW {workflow_file_path} workflow_alias
-                HOOK_WORKFLOW workflow_alias PRE_EXPERIMENT
-                """
-            )
-        )
-
     class SomeScript(ErtScript):
         def run(self, random_seed: int):
             pass
@@ -2098,24 +2069,8 @@ def run(self, random_seed: int):
     ErtConfig.from_file("config.ert")
 
 
-@pytest.mark.usefixtures("use_tmpdir")
+@pytest.mark.usefixtures("use_tmpdir", "setup_workflow_file")
 def test_ert_script_hook_pre_experiment_essettings_fails():
-    workflow_file_path = os.path.join(os.getcwd(), "workflow")
-    with open(workflow_file_path, mode="w", encoding="utf-8") as fh:
-        fh.write("TEST_SCRIPT")
-
-    with open("config.ert", mode="w", encoding="utf-8") as fh:
-        fh.write(
-            dedent(
-                f"""
-                NUM_REALIZATIONS 1
-
-                LOAD_WORKFLOW {workflow_file_path} workflow_alias
-                HOOK_WORKFLOW workflow_alias PRE_EXPERIMENT
-                """
-            )
-        )
-
     class SomeScript(ErtScript):
         def run(self, es_settings: ESSettings):
             pass