Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interim modal for User Profile email address warning messages(March release) #1181

Open
rohanjay10 opened this issue Dec 24, 2024 · 17 comments
Assignees
Labels
CCC Priority 2 Issues will be prioritized in the upcoming/next release

Comments

@rohanjay10
Copy link
Collaborator

rohanjay10 commented Dec 24, 2024

(Ops suggestion is to put this on the backlog for a later release)

Interim modal that would appear after User Profile is submitted, but before the UP review page, to indicate emails deemed risky by Sendgrid Email Validation.

  • "This email address may be invalid. Please double check your entry before continuing"

Image

@sonyekere sonyekere added the CCC Priority 2 Issues will be prioritized in the upcoming/next release label Dec 24, 2024
@rohanjay10 rohanjay10 changed the title Interim modal for User Profile email address warning messages Interim modal for User Profile email address warning messages(February release) Jan 16, 2025
@jhflorey jhflorey moved this from Backlog to Development in Connect Development and Support Jan 30, 2025
@depietrodeanna
Copy link
Collaborator

@sonyekere I do not see a need to update this modal language. I can get this translated to Spanish and add that here. @robertsamm do you agree the language is OK?

@robertsamm
Copy link
Collaborator

@depietrodeanna I agree the language in the message looks ok, should we change the all caps 'WARNING' at the top of the modal?

@depietrodeanna
Copy link
Collaborator

yes definitely- I don't think we need a title necessarily. Dev team, can we simply remove "Warning" from this modal?

@rohanjay10
Copy link
Collaborator Author

rohanjay10 commented Jan 30, 2025

Hi @jhflorey @HanaShiho could we remove the "WARNING" portion at the top out of the interim warning modal here (part of the February release)

Image

@sonyekere sonyekere added CCC Priority 1 Issues to be addressed in the current release and removed CCC Priority 2 Issues will be prioritized in the upcoming/next release labels Jan 31, 2025
@HanaShiho
Copy link
Collaborator

Thanks @rohanjay10 I'm fine with removing the title from the modal

@rohanjay10
Copy link
Collaborator Author

No problem @HanaShiho . Hi @jhflorey I think we can remove the "WARNING" from the warning modal box with the consensus

Hi @jhflorey @HanaShiho could we remove the "WARNING" portion at the top out of the interim warning modal here (part of the February release)

Image

@jhflorey
Copy link
Collaborator

jhflorey commented Feb 3, 2025

@rohanjay10 Got it.

@jhflorey
Copy link
Collaborator

jhflorey commented Feb 4, 2025

@rohanjay10 @robertsamm @depietrodeanna Does it look good?

Image Image

@depietrodeanna
Copy link
Collaborator

@jhflorey yes looks good to me,

@robertsamm
Copy link
Collaborator

@jhflorey agreed - looks good!

@sonyekere sonyekere added CCC Priority 2 Issues will be prioritized in the upcoming/next release and removed CCC Priority 1 Issues to be addressed in the current release labels Feb 4, 2025
@jhflorey
Copy link
Collaborator

jhflorey commented Feb 5, 2025

@robertsamm @depietrodeanna @rohanjay10 my code changes are ready in dev. We can test it.

@HanaShiho
Copy link
Collaborator

Thanks, @jhflorey. The original post says it will appear when email address are deemed risky; so does that mean email addresses tagged as risky by SendGrid will get the warning message, while invalid emails get nothing? Also, would this only apply to new account creation, or would it also appear when the preferred email address is updated in the existing UP?

@jhflorey
Copy link
Collaborator

jhflorey commented Feb 6, 2025

@HanaShiho the invalid email will have the red error text below this email textbox.
@rohanjay10 Do we need to implement this feature for updating email in my profile page?

@rohanjay10
Copy link
Collaborator Author

Hi @HanaShiho this is the error text Jessica mentioned above:

Image @jhflorey for your question we'd need input from @robertsamm @HanaShiho @depietrodeanna if the warning message/modal needs to be implemented in MyProfiles page when pts are editing their email. Invalid emails are shown the error message above.

@sonyekere mentioned that the Interim warning modal would be part of the March release, so if it also needed to be implemented in MyProfiles I assume it would be a lower priority after it was implemented in the main User Profile page.
Please let me know if the above info needs to be updated.

@HanaShiho
Copy link
Collaborator

Thanks, Rohan. @brotzmanmj also confirmed we currently have a warning for invalid messages in prod, so the above change will be tested with risky messages.

My question is, if someone updated their preferred email via SMDB or PWA, would that updated email address be validated by SendGrid? I believe when the existing preferred email is updated in PWA, it must pass SG validation, but @jhflorey @rohanjay10, can you please confirm for both SMDB and PWA? This will help clarify my last question about how a warning msg should behave when updating the existing UP.

@sonyekere
Copy link
Collaborator

Hello All. @jhflorey , @rohanjay10 and @HanaShiho a decision has been made to pause the conversation on this. There's not enough time or bandwidth to address the follow-up questions before the dev freeze on 2/14. This will be addressed in March. Thank you!

@sonyekere sonyekere changed the title Interim modal for User Profile email address warning messages(February release) Interim modal for User Profile email address warning messages(March release) Feb 6, 2025
@jhflorey
Copy link
Collaborator

jhflorey commented Feb 7, 2025

@HanaShiho just want to confirm

  • In the SMDB we have not implement email validation.
  • In the PWA user cannot update the existing preferred email if it is invalid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CCC Priority 2 Issues will be prioritized in the upcoming/next release
Projects
Development

No branches or pull requests

8 participants