-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interim modal for User Profile email address warning messages(March release) #1181
Comments
@sonyekere I do not see a need to update this modal language. I can get this translated to Spanish and add that here. @robertsamm do you agree the language is OK? |
@depietrodeanna I agree the language in the message looks ok, should we change the all caps 'WARNING' at the top of the modal? |
yes definitely- I don't think we need a title necessarily. Dev team, can we simply remove "Warning" from this modal? |
Hi @jhflorey @HanaShiho could we remove the "WARNING" portion at the top out of the interim warning modal here (part of the February release) |
Thanks @rohanjay10 I'm fine with removing the title from the modal |
No problem @HanaShiho . Hi @jhflorey I think we can remove the "WARNING" from the warning modal box with the consensus
|
@rohanjay10 Got it. |
@rohanjay10 @robertsamm @depietrodeanna Does it look good? ![]() ![]() |
@jhflorey yes looks good to me, |
@jhflorey agreed - looks good! |
@robertsamm @depietrodeanna @rohanjay10 my code changes are ready in dev. We can test it. |
Thanks, @jhflorey. The original post says it will appear when email address are deemed risky; so does that mean email addresses tagged as risky by SendGrid will get the warning message, while invalid emails get nothing? Also, would this only apply to new account creation, or would it also appear when the preferred email address is updated in the existing UP? |
@HanaShiho the invalid email will have the red error text below this email textbox. |
Hi @HanaShiho this is the error text Jessica mentioned above: ![]() @sonyekere mentioned that the Interim warning modal would be part of the March release, so if it also needed to be implemented in MyProfiles I assume it would be a lower priority after it was implemented in the main User Profile page. |
Thanks, Rohan. @brotzmanmj also confirmed we currently have a warning for invalid messages in prod, so the above change will be tested with risky messages. My question is, if someone updated their preferred email via SMDB or PWA, would that updated email address be validated by SendGrid? I believe when the existing preferred email is updated in PWA, it must pass SG validation, but @jhflorey @rohanjay10, can you please confirm for both SMDB and PWA? This will help clarify my last question about how a warning msg should behave when updating the existing UP. |
Hello All. @jhflorey , @rohanjay10 and @HanaShiho a decision has been made to pause the conversation on this. There's not enough time or bandwidth to address the follow-up questions before the dev freeze on 2/14. This will be addressed in March. Thank you! |
@HanaShiho just want to confirm
|
(Ops suggestion is to put this on the backlog for a later release)
Interim modal that would appear after User Profile is submitted, but before the UP review page, to indicate emails deemed risky by Sendgrid Email Validation.
The text was updated successfully, but these errors were encountered: