Skip to content

Commit 219cf8c

Browse files
ljharbljharb
committed
[eslint] switch to @babel/eslint-parser, fix linting
1 parent d39e496 commit 219cf8c

File tree

47 files changed

+138
-156
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

47 files changed

+138
-156
lines changed

‎.eslintignore

-49
This file was deleted.

‎.eslintrc

+29-17
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,17 @@
44
"env": {
55
"node": true,
66
},
7-
"parser": "babel-eslint",
7+
"parser": "@babel/eslint-parser",
8+
"ignorePatterns": [
9+
"/build",
10+
"_book",
11+
"packages/*/build/",
12+
// Temporarily copied
13+
"packages/*/LICENSE.md",
14+
"packages/enzyme/README.md",
15+
"packages/enzyme-adapter-react-*/README.md",
16+
"packages/enzyme-adapter-utils*/README.md",
17+
],
818
"rules": {
919
"id-length": 0,
1020
"react/no-find-dom-node": 1,
@@ -23,43 +33,45 @@
2333
"devDependencies": true,
2434
}],
2535
"comma-dangle": [2, {
26-
arrays: "always-multiline",
27-
objects: "always-multiline",
28-
imports: "always-multiline",
29-
exports: "always-multiline",
30-
functions: "ignore",
36+
"arrays": "always-multiline",
37+
"objects": "always-multiline",
38+
"imports": "always-multiline",
39+
"exports": "always-multiline",
40+
"functions": "ignore",
3141
}],
3242
"strict": [2, "safe"],
3343
"prefer-destructuring": 0,
3444
"prefer-template": 0,
3545
},
3646
"parserOptions": {
37-
sourceType: "script",
47+
"sourceType": "script",
3848
},
3949
},
4050
{
4151
"files": [
42-
"*.md",
4352
"**/*.md",
53+
"**/*.md/**"
4454
],
45-
"plugins": [
46-
"markdown"
47-
],
55+
"extends": ["plugin:markdown/recommended"],
4856
"rules": {
4957
"class-methods-use-this": 0,
50-
"import/no-unresolved": 0,
51-
"import/no-extraneous-dependencies": 0,
5258
"import/extensions": 0,
59+
"import/no-extraneous-dependencies": 0,
60+
"import/no-unresolved": 0,
61+
"import/prefer-default-export": 0,
5362
"max-len": 0,
54-
"no-unused-vars": 0,
5563
"no-console": 0,
5664
"no-undef": 0,
57-
"react/react-in-jsx-scope": 0,
65+
"no-unused-vars": 0,
5866
"react/jsx-filename-extension": 0,
67+
"react/jsx-fragments": 0,
5968
"react/jsx-no-undef": 0,
60-
"react/no-multi-comp": 0,
69+
"react/jsx-no-useless-fragment": 0,
6170
"react/jsx-one-expression-per-line": 0,
62-
"react/jsx-fragments": 0,
71+
"react/no-multi-comp": 0,
72+
"react/no-unknown-property": 0,
73+
"react/no-unused-class-component-methods": 0,
74+
"react/react-in-jsx-scope": 0,
6375
},
6476
},
6577
],

‎docs/api/ReactWrapper/props.md

-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ This method is a reliable way of accessing the props of a node; `wrapper.instanc
77

88
#### Example
99
```jsx
10-
1110
import PropTypes from 'prop-types';
1211

1312
function MyComponent(props) {

‎docs/api/ReactWrapper/renderProp.md

+13-11
Original file line numberDiff line numberDiff line change
@@ -50,17 +50,19 @@ Mouse.propTypes = {
5050
```
5151

5252
```jsx
53-
const App = () => (
54-
<div style={{ height: '100%' }}>
55-
<Mouse
56-
render={(x = 0, y = 0) => (
57-
<h1>
58-
The mouse position is ({x}, {y})
59-
</h1>
60-
)}
61-
/>
62-
</div>
63-
);
53+
function App() {
54+
return (
55+
<div style={{ height: '100%' }}>
56+
<Mouse
57+
render={(x = 0, y = 0) => (
58+
<h1>
59+
The mouse position is ({x}, {y})
60+
</h1>
61+
)}
62+
/>
63+
</div>
64+
);
65+
}
6466
```
6567

6668
##### Testing with no arguments

‎docs/api/ReactWrapper/simulate.md

+8-6
Original file line numberDiff line numberDiff line change
@@ -48,12 +48,14 @@ expect(wrapper.find('.clicks-1').length).to.equal(1);
4848
#### Example `functional component`
4949

5050
```jsx
51-
const Foo = ({ width, height, onChange }) => (
52-
<div>
53-
<input name="width" value={width} onChange={onChange} />
54-
<input name="height" value={height} onChange={onChange} />
55-
</div>
56-
);
51+
function Foo({ width, height, onChange }) {
52+
return (
53+
<div>
54+
<input name="width" value={width} onChange={onChange} />
55+
<input name="height" value={height} onChange={onChange} />
56+
</div>
57+
);
58+
}
5759
Foo.propTypes = {
5860
width: PropTypes.number.isRequired,
5961
height: PropTypes.number.isRequired,

‎docs/api/ReactWrapper/simulateError.md

-2
Original file line numberDiff line numberDiff line change
@@ -74,5 +74,3 @@ expect(spy.args).to.deep.equal([
7474
},
7575
]);
7676
```
77-
78-

‎docs/api/ShallowWrapper/props.md

-1
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@ This method is a reliable way of accessing the props of a node; `wrapper.instanc
99

1010
#### Example
1111
```jsx
12-
1312
import PropTypes from 'prop-types';
1413

1514
function MyComponent(props) {

‎docs/api/ShallowWrapper/renderProp.md

+13-11
Original file line numberDiff line numberDiff line change
@@ -50,17 +50,19 @@ Mouse.propTypes = {
5050
```
5151

5252
```jsx
53-
const App = () => (
54-
<div style={{ height: '100%' }}>
55-
<Mouse
56-
render={(x = 0, y = 0) => (
57-
<h1>
58-
The mouse position is ({x}, {y})
59-
</h1>
60-
)}
61-
/>
62-
</div>
63-
);
53+
function App() {
54+
return (
55+
<div style={{ height: '100%' }}>
56+
<Mouse
57+
render={(x = 0, y = 0) => (
58+
<h1>
59+
The mouse position is ({x}, {y})
60+
</h1>
61+
)}
62+
/>
63+
</div>
64+
);
65+
}
6466
```
6567

6668
##### Testing with no arguments

‎docs/api/ShallowWrapper/simulate.md

+8-6
Original file line numberDiff line numberDiff line change
@@ -48,12 +48,14 @@ expect(wrapper.find('.clicks-1').length).to.equal(1);
4848
#### Example `functional component`
4949

5050
```jsx
51-
const Foo = ({ width, height, onChange }) => (
52-
<div>
53-
<input name="width" value={width} onChange={onChange} />
54-
<input name="height" value={height} onChange={onChange} />
55-
</div>
56-
);
51+
function Foo({ width, height, onChange }) {
52+
return (
53+
<div>
54+
<input name="width" value={width} onChange={onChange} />
55+
<input name="height" value={height} onChange={onChange} />
56+
</div>
57+
);
58+
}
5759
Foo.propTypes = {
5860
width: PropTypes.number.isRequired,
5961
height: PropTypes.number.isRequired,

‎docs/api/ShallowWrapper/simulateError.md

+1-3
Original file line numberDiff line numberDiff line change
@@ -73,6 +73,4 @@ expect(spy.args).to.deep.equal([
7373
in WrapperComponent`,
7474
},
7575
]);
76-
```
77-
78-
76+
```

‎docs/api/shallow.md

-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,6 @@ describe('<MyComponent />', () => {
3737
expect(onButtonClick).to.have.property('callCount', 1);
3838
});
3939
});
40-
4140
```
4241

4342
## `shallow(node[, options]) => ShallowWrapper`

‎docs/guides/lab.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ const Code = require('code');
1313
const Lab = require('lab');
1414

1515
const lab = Lab.script();
16-
exports.lab = lab;
16+
export { lab };
1717

1818
lab.suite('A suite', () => {
1919
lab.test('calls componentDidMount', (done) => {

‎docs/guides/migration-from-2-to-3.md

+9-5
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,9 @@ const ICONS = {
7878
failure: <Icon name="exclamation-mark" />,
7979
};
8080

81-
const StatusLabel = ({ id, label }) => <div>{ICONS[id]}{label}{ICONS[id]}</div>;
81+
function StatusLabel({ id, label }) {
82+
return <div>{ICONS[id]}{label}{ICONS[id]}</div>;
83+
}
8284
```
8385

8486
```js
@@ -504,11 +506,13 @@ Consider this example:
504506
<!-- eslint react/prop-types: 0, react/prefer-stateless-function: 0, react/jsx-props-no-spreading: 0 -->
505507

506508
```js
507-
const HelpLink = ({ text, ...rest }) => <a {...rest}>{text}</a>;
509+
function HelpLink({ text, ...rest }) {
510+
return <a {...rest}>{text}</a>;
511+
}
508512

509-
const HelpLinkContainer = ({ text, ...rest }) => (
510-
<HelpLink text={text} {...rest} />
511-
);
513+
function HelpLinkContainer({ text, ...rest }) {
514+
return <HelpLink text={text} {...rest} />;
515+
}
512516

513517
const wrapper = mount(<HelpLinkContainer aria-expanded="true" text="foo" />);
514518
```

‎docs/guides/mocha.md

+1-2
Original file line numberDiff line numberDiff line change
@@ -22,5 +22,4 @@ describe('<Foo />', () => {
2222
expect(Foo.prototype.componentDidMount).to.have.property('callCount', 1);
2323
});
2424
});
25-
26-
```
25+
```

‎package.json

+4-4
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
"clean": "lerna run clean",
1616
"prelint": "npm run lint:root",
1717
"lint": "lerna exec --parallel 'npm run lint -- --quiet'",
18-
"lint:root": "eslint . --ext=js,md,jsx --ignore-pattern=packages/ --ignore-path .eslintignore",
18+
"lint:root": "eslint . --ext=js,md,jsx --ignore-pattern=packages/",
1919
"check": "lerna run lint && npm run test:all",
2020
"prebuild": "npm run clean",
2121
"build": "lerna run build",
@@ -62,20 +62,20 @@
6262
"devDependencies": {
6363
"@babel/cli": "^7.19.3",
6464
"@babel/core": "^7.19.3",
65+
"@babel/eslint-parser": "^7.19.1",
6566
"@babel/node": "^7.19.1",
6667
"@babel/register": "^7.18.9",
67-
"babel-eslint": "^10.1.0",
6868
"babel-loader": "^8.2.2",
6969
"babel-plugin-add-module-exports": "^1.0.4",
7070
"babel-plugin-transform-replace-object-assign": "^2.0.0",
7171
"babel-preset-airbnb": "^4.5.0",
7272
"chai": "^4.3.4",
73-
"eslint": "^8.24.0",
73+
"eslint": "^8.26.0",
7474
"eslint-config-airbnb": "^19.0.4",
7575
"eslint-plugin-import": "^2.26.0",
7676
"eslint-plugin-jsx-a11y": "^6.6.1",
7777
"eslint-plugin-markdown": "^3.0.0",
78-
"eslint-plugin-react": "^7.31.8",
78+
"eslint-plugin-react": "^7.31.10",
7979
"eslint-plugin-react-hooks": "^4.6.0",
8080
"gitbook-cli": "^1.0.1",
8181
"gitbook-plugin-anchors": "^0.7.1",

‎packages/enzyme-adapter-react-13/.eslintrc

+3-2
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,10 @@
11
{
22
"extends": "airbnb",
3-
"parser": "babel-eslint",
3+
"parser": "@babel/eslint-parser",
44
"root": true,
5+
"ignorePatterns": ["build/"],
56
"rules": {
6-
"max-classes-per-file": 0,
7+
"max-classes-per-file": 0,
78
"max-len": 0,
89
"react/no-find-dom-node": 0,
910
"react/no-multi-comp": 0,

‎packages/enzyme-adapter-react-13/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@
5151
"devDependencies": {
5252
"@babel/cli": "^7.19.3",
5353
"@babel/core": "^7.19.3",
54-
"babel-eslint": "^10.1.0",
54+
"@babel/eslint-parser": "^7.19.1",
5555
"babel-plugin-add-module-exports": "^1.0.4",
5656
"babel-plugin-transform-replace-object-assign": "^2.0.0",
5757
"babel-preset-airbnb": "^4.5.0",

‎packages/enzyme-adapter-react-14/.eslintrc

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
{
22
"extends": "airbnb",
3-
"parser": "babel-eslint",
3+
"parser": "@babel/eslint-parser",
44
"root": true,
5+
"ignorePatterns": ["build/"],
56
"rules": {
67
"max-len": 0,
78
"react/no-find-dom-node": 0,

‎packages/enzyme-adapter-react-14/package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@
5555
"devDependencies": {
5656
"@babel/cli": "^7.19.3",
5757
"@babel/core": "^7.19.3",
58-
"babel-eslint": "^10.1.0",
58+
"@babel/eslint-parser": "^7.19.1",
5959
"babel-plugin-add-module-exports": "^1.0.4",
6060
"babel-plugin-transform-replace-object-assign": "^2.0.0",
6161
"babel-preset-airbnb": "^4.5.0",

0 commit comments

Comments
 (0)