-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support BackendCluster for Remote JWKS #5011
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5011 +/- ##
==========================================
- Coverage 66.84% 66.80% -0.04%
==========================================
Files 211 210 -1
Lines 32916 32943 +27
==========================================
+ Hits 22004 22009 +5
- Misses 9586 9598 +12
- Partials 1326 1336 +10 ☔ View full report in Codecov by Sentry. |
00cf16b
to
2a68252
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SecuritcyPolicy
validation has been moved from the xds translation to the API translation. This change allows validation errors to be caught earlier and reflected in the SecurityPolicy
status.
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
2a68252
to
9c6e27a
Compare
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
case spec.ExtAuth != nil: | ||
sum++ | ||
case spec.OIDC != nil: | ||
sum++ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove this empty spec check because other policy types don't do this check. We can apply the check to all the policy types through CEL in a follow-up PR if it's needed.
@@ -1,154 +0,0 @@ | |||
// Copyright Envoy Gateway Authors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file was deleted from the API package and the validations have been moved into the gatewapi translator.
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
internal/cmd/egctl/testdata/translate/out/invalid-securitypolicy.all.yaml
Show resolved
Hide resolved
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
@zhaohuabing Thank you for working on this! It's been blocking us from adopting Envoy Gateway and I'm looking forward to seeing this merged. I notice this PR doesn't update the documentation, it would be good to see an example added there. Also for using OIDC with an internal certificate, it took me a couple of hours to work out how to do that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks !
Will update the docs in a follow-up PR.
You can find an example for OIDC here: https://gateway.envoyproxy.io/docs/tasks/security/oidc/#connect-to-an-oidc-provider-with-self-signed-certificate |
This PR introduces support for representing JWT remote JWKS as
Backend
resources. With this enhancement, users can:BackendTLSPolicy
to define a self-signed CA for the remote JWKSrmoteJWKS.backendSettings.retry
to sepecify the retry policy for the remote JWKSImplements: #3536
Release Notes: Yes