You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While GCS uses long for what it calls blob generation, AWS uses Stringas described here:
Each object has a version ID, whether or not S3 Versioning is enabled. (...) If you enable S3 Versioning, Amazon S3 assigns a version ID value for the object. This value distinguishes that object from other versions of the same key.
(...)
Only Amazon S3 generates version IDs, and they cannot be edited. Version IDs are Unicode, UTF-8 encoded, URL-ready, opaque strings that are no more than 1,024 bytes long. The following is an example:
make the blob versioning type Generic, <Long> for GCS, <String> for S3, and maybe <Void> for local and other implementations which do not support any blob versioning schemes
take the generic type into use where applicable
add related functionality such as adding helper methods supportsBlobVersioning(), hasBlobVersioningEnabled(), listBlobVersions()
add version awareness to supported operations, such as Optional<V> version field to BlobDescriptor
This is not high on priority, but something I'd see as potentially quite useful for longer term development.
Also somewhat related, I'd reduce the overall number of overloads in general through similar descriptor objects as parameters as BlobDescriptor for upload.
The text was updated successfully, but these errors were encountered:
Some of the available API methods in
BlobStoreRepository
expose the blob versioning data, for example hererutebanken-helpers/storage/src/main/java/org/rutebanken/helper/storage/repository/BlobStoreRepository.java
Lines 42 to 55 in 13526eb
While GCS uses
long
for what it calls blob generation, AWS usesString
as described here:As such, I'd suggest the following:
<Long>
for GCS,<String>
for S3, and maybe<Void>
for local and other implementations which do not support any blob versioning schemessupportsBlobVersioning()
,hasBlobVersioningEnabled()
,listBlobVersions()
Optional<V> version
field toBlobDescriptor
This is not high on priority, but something I'd see as potentially quite useful for longer term development.
Also somewhat related, I'd reduce the overall number of overloads in general through similar descriptor objects as parameters as
BlobDescriptor
for upload.The text was updated successfully, but these errors were encountered: