Fix warning messages from PyDict_GetItem #1818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would make sense to review other uses of |
|
Thanks, @dpinte! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR silences warning messages from
PyDict_GetItemin cases where we're trying to look up something that's not hashable.Note that replacing
PyDict_GetItemwithPyDict_GetItemWithErrormeans replacing something that can't raise an exception with something that can, but in both cases we already have error paths present that handle the case where an exception is set. (In thevalidate_trait_mapcase,raise_traits_errortakes care of clearing any existing error. Arguably it should chain the errors instead, but that's a separate discussion.)Closes #1817