Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exercise the 'assert' statements in CI builds #1763

Open
mdickinson opened this issue Dec 8, 2023 · 0 comments
Open

Exercise the 'assert' statements in CI builds #1763

mdickinson opened this issue Dec 8, 2023 · 0 comments
Labels
component: build Issues related to etstool.py, CI and other build machinery component: core Issues related to the core library type: cleanup

Comments

@mdickinson
Copy link
Member

The ctraits.c source contains various assert statements, but those assert statements aren't being executed in our CI runs, because we inherit a DNDEBUG setting from the Python build settings. For CI runs, it would be good to build the ctraits extension using undef_macros=["NDEBUG"] so that the asserts are exercised.
@mdickinson mdickinson added type: cleanup component: build Issues related to etstool.py, CI and other build machinery component: core Issues related to the core library labels Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: build Issues related to etstool.py, CI and other build machinery component: core Issues related to the core library type: cleanup
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mdickinson