Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better logging when electron/self-hosted doesn't start up correctly. #37

Closed
daed opened this issue Dec 4, 2018 · 4 comments
Closed
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@daed
Copy link
Member

daed commented Dec 4, 2018

See Laverna/laverna#985 for background.

Docker competes for port 9000. Maybe we can display something informative if the webserver can't start because port is in use?

@daed daed added enhancement New feature or request good first issue Good for newcomers labels Dec 4, 2018
@Maks-s
Copy link
Member

Maks-s commented Dec 8, 2018

Or we can change the port, and if it's also used then check the next one.
As we don't want to check 56535 port, we can just check for number 9000 to 9000 + X

@daed
Copy link
Member Author

daed commented Dec 10, 2018

That would work for desktop versions. If you run it as a server, I would think that you'd wouldn't want inconsistency there.

@pms1969
Copy link

pms1969 commented Jan 23, 2019

VSCode does this very well if you're looking for an example.

@daed
Copy link
Member Author

daed commented Mar 12, 2019

@Maks-s put in a check and error message for this via #74. I don't know if we should talk about changing ports to something less commonly used or if this is enough, but I think I'm satisfied with, at least for the time being.

@daed daed closed this as completed Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants