Tasks not awaited after calling cancel in shutdown

[PokkaKiyo]

Hi,

Happened to come across the following snippet of code in the shutdown logic while trying to understand the graceful shutdown logic in server.py:

            for t in self.server_state.tasks:
                if sys.version_info < (3, 9):  # pragma: py-gte-39
                    t.cancel()
                else:  # pragma: py-lt-39
                    t.cancel(msg="Task cancelled, timeout graceful shutdown exceeded")

After calling cancel on an asyncio Task, the Task should be awaited, which is not happening here (and across a handful of places in the code base), since Task.cancel() alone does not cancel the task.

https://docs.python.org/3/library/asyncio-task.html#asyncio.Task.cancel

Is this worth changing/fixing? I suppose adding a simple loop across the tasks to await them and catch the CancelledError should be sufficient?

Thanks!