Module config.py's create_ssl_context
ssl_version param validate to int alone
#2347
Murugaraju
started this conversation in
General
Replies: 1 comment
-
In using uvicorn with SSL, I've noticed a few of these kinds of issues. For example, the uvicorn documentation just says verifymode is an int, but not that verifymode 1 makes client certificates optional. Using strings would make these choices much easier than integers. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Description of problem
Hey Team,
I had some settings for the gunicorn config in saved in cfg file. First scenario is the execution of gunicorn is done via shell file, the file containing the code as below
During above scenario the execution of gunicorn done via the worker
UvicornWorker
. The problem found is as belowSecond I moved the
--ssl-version=5
from command arg to cfg file as belowssl_version = 5
it worked.
uvicorn/uvicorn/config.py
Line 106 in 22873a9
Any chance that this explicit annotation to ssl_verification can be removed. Thought of giving the team a visibility on the scenario I faced 😅
Beta Was this translation helpful? Give feedback.
All reactions