ColourizedFormatter cannot work after packaging with pyinstaller on Windows

[lovexuan]

After packaging with pyinstaller, sys.stderr will be None, and at line 47 of uvicorn.logging, it called sys.stdout.isatty() directly. So it will always raise an AttributeError like:

Traceback (most recent call last):
  File "logging\config.py", line 543, in configure
  File "logging\config.py", line 655, in configure_formatter
  File "logging\config.py", line 474, in configure_custom
  File "uvicorn\logging.py", line 47, in __init__
AttributeError: 'NoneType' object has no attribute 'isatty'

Of cause I can construct a custom logger config without ColourizedFormatter, but I think the default logger should avoid this error :)

[Kludex]

Do you have an MRE?

[lovexuan]

Do you have an MRE?

Uh yeah, the code is unnecessary, but I can show you:

import fastapi
import uvicorn

app = fastapi.FastAPI()


@app.get('/')
def anything():
    return 'Hello World'


uvicorn.run(app)

Then packaging it by pyinstaller:

pyinstaller test.py -w

Then run the dist exe.

dist\test\test.exe

Also, sys.stdin is also None, so line 37 of uvicorn._subprocess will also raise AttributeError. All of these should be checked.

[Kludex]

Does this PR solve your issue? #1947

[lovexuan]

Does this PR solve your issue? #1947

Half. Should also check sys.stderr at line 47 of uvicorn.logging