Skip to content

Commit e63b659

Browse files
authored
Fix encode host (#2886)
* Fix requiring dot literal rather than any character in IPv4 * Add check to prevent future errors
1 parent 3ba5fe0 commit e63b659

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

httpx/_urlparse.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -87,7 +87,7 @@
8787

8888
# We use these simple regexs as a first pass before handing off to
8989
# the stdlib 'ipaddress' module for IP address validation.
90-
IPv4_STYLE_HOSTNAME = re.compile(r"^[0-9]+.[0-9]+.[0-9]+.[0-9]+$")
90+
IPv4_STYLE_HOSTNAME = re.compile(r"^[0-9]+\.[0-9]+\.[0-9]+\.[0-9]+$")
9191
IPv6_STYLE_HOSTNAME = re.compile(r"^\[.*\]$")
9292

9393

tests/test_urlparse.py

+6
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,12 @@ def test_urlparse_normalized_host():
4545
assert url.host == "example.com"
4646

4747

48+
def test_urlparse_ipv4_like_host():
49+
"""rare host names used to quality as IPv4"""
50+
url = httpx.URL("https://023b76x43144/")
51+
assert url.host == "023b76x43144"
52+
53+
4854
def test_urlparse_valid_ipv4():
4955
url = httpx.URL("https://1.2.3.4/")
5056
assert url.host == "1.2.3.4"

0 commit comments

Comments
 (0)