Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please release lib version #103

Closed
Tracked by #113
ItaloCobains opened this issue Oct 26, 2023 · 4 comments
Closed
Tracked by #113

Please release lib version #103

ItaloCobains opened this issue Oct 26, 2023 · 4 comments

Comments

@ItaloCobains
Copy link

I need the functionality of a feature that sends the redis url password to asyncio_redis version 0.2.0, but I cloned your repository and saw that it is already available. I have an app in production that really needs this. I'll end up having to open a fork of your app or use another lib if that doesn't work.

0.2.0:

    async def connect(self) -> None:
        self._pub_conn = await asyncio_redis.Connection.create(self._host, self._port)
        self._sub_conn = await asyncio_redis.Connection.create(self._host, self._port)
        self._subscriber = await self._sub_conn.start_subscribe()

current version repo:

    async def connect(self) -> None:
        kwargs = {"host": self._host, "port": self._port, "password": self._password}
        self._pub_conn = await asyncio_redis.Connection.create(**kwargs)
        self._sub_conn = await asyncio_redis.Connection.create(**kwargs)
        self._subscriber = await self._sub_conn.start_subscribe()
@Mark90
Copy link

Mark90 commented Mar 21, 2024

I'm also wondering if there is any chance a new release can be made?

We'd like to use the rediss:// backend for which a fix is in the master branch. This branch seems to work fine in our application when installing it directly.

@Mark90
Copy link

Mark90 commented Mar 22, 2024

In case anyone read my previous comment and got their hopes up, using rediss:// actually gives problems in the asyncio_redis library that broadcaster depends on. So I was wrong in saying that master branch works fine (for this particular usecase anyway)

@alex-oleshkevich
Copy link
Member

@Kludex let's merge #110 and #111 and publish a new version?

@alex-oleshkevich alex-oleshkevich mentioned this issue Apr 3, 2024
19 tasks
@alex-oleshkevich
Copy link
Member

Tracked in #113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants