Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider simplifying 3rd_party imports #12

Open
enbnt opened this issue Feb 27, 2023 · 0 comments
Open

Consider simplifying 3rd_party imports #12

enbnt opened this issue Feb 27, 2023 · 0 comments

Comments

@enbnt
Copy link
Owner

enbnt commented Feb 27, 2023

Problem

The way that we make use of imports on third party dependencies
requires a kind of shortened special incantation. Example:

"@maven//:com_twitter_util_core_2_13",

will pull in com.twitter util-core project that is built against
the Scala 2.13 target.

Proposal

Setup special BUILD.bazel targets in our 3rd_party package
that allows us to more easy specify something like

"//3rd_party/twitter/util/util-core"

as a build dependency.

Considerations

This is either trivially easy or a massive undertaking. We don't
have the ability to re-use the BUILD.bazel files from Twitter's
OSS projects.

Other considerations might be to fork the necessary dependencies
needed for our example projects or to fork the projects and setup
isolated BUILD.bazel files that would work IFF we cannot easily
alias our maven jar dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant