Should we move @with_all_fs test into test_other.py

[sbc100]

There are bunch of decorators in use now in test_core.py including @with_all_fs test and @also_with_nodefs_both.

Having these in test_core.py mean that we have a combinatorial explosion of tests here. Should we move these tests into test_other.py? @kripken is there any reason to keep these FS tests in test_core.py?

[sbc100]

@kripken

[kripken]

Some FS tests benefit from coverage of optimizations, our JS optimizer and also closure. Another factor is that by being in core we get coverage of wasm64 and sanitizers.

But probably a lot of them can be moved to other. Deciding which is hard to automate, though, I worry.

[sbc100]

OK, closing this for.

Interestingly enough the other suite take a lot longer to run than the core suite on my machine.. so maybe moving stuff isn't the best idea anyway.

other --skip-slow: 358.455s
core0 --skip-slow: 168.206s
core2 --skip-slow: 210.055s

[kripken]

Yeah, if we wanted to reduce wall time we'd want to split up other first, I guess. But the total work of all the core* modes is pretty high, and for FS I do agree it is mostly wasteful.