Skip to content

cores.test_minimal_runtime_safe_heap is due to acorn-optimizer issue #23422

Closed
@sbc100

Description

@sbc100

It seems like when applyDCEGraphRemovals is run the comments that were meant for the statement prior get propogated forward. This result is closure getting confused:

See #23403 (comment)

Here is the before and after of applyDCEGraphRemovals:

var wasmImports = {                                                              
  /** @export */ alignfault,                                                     
  /** @export */ emscripten_console_log: _emscripten_console_log,                
  /** @export */ emscripten_resize_heap: _emscripten_resize_heap,                
  /** @export */ segfault                                                        
};                                                                               
                                                                                 
function assignWasmExports(wasmExports) {                                        
  _main = wasmExports["main"];                                                   
  _emscripten_get_sbrk_ptr = wasmExports["emscripten_get_sbrk_ptr"];             
  _sbrk = wasmExports["sbrk"];                                                   
  _emscripten_stack_get_base = wasmExports["emscripten_stack_get_base"];         
  __emscripten_stack_restore = wasmExports["_emscripten_stack_restore"];         
  __emscripten_stack_alloc = wasmExports["_emscripten_stack_alloc"];             
  _emscripten_stack_get_current = wasmExports["emscripten_stack_get_current"];   
} 
var wasmImports = {                                                              
  /** @export */ emscripten_console_log: _emscripten_console_log                 
};                                                                               
                                                                                 
/** @export */ function assignWasmExports(wasmExports) {                         
  _main = wasmExports["main"];                                                   
}            

Here you can see the @export comment gets erroneous moved to match the assignWasmExports function... where is it not valid.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions