Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filenames starting with 0 should be labeled Page 1, not Page 0 #2039

Open
eporter23 opened this issue Nov 18, 2022 · 1 comment
Open

Filenames starting with 0 should be labeled Page 1, not Page 0 #2039

eporter23 opened this issue Nov 18, 2022 · 1 comment
Labels

Comments

@eporter23
Copy link
Contributor

eporter23 commented Nov 18, 2022

Related to work done in https://app.zenhub.com/workspaces/digital-library-project-5bf484ae4b5806bc2bf6875b/issues/emory-libraries/dlp-curate/1984

When re-testing all the preprocessors prior to production launch, I am seeing that if we set the Starting Page Number to 0 instead of 1, the fileset_label or title gets set to Page 0 where it should be Page 1.

To avoid confusion, perhaps we could also relabel the form attribute to "Starting Page Filename" . This parameter in the preprocessor is intended to accommodate filename sequences that start with 0000.tif or 00000000.tif instead of the usual 0001.tif or 00000001.tif.

Current Zizia output:

Screen Shot 2022-11-18 at 3.21.15 PM.png

Current Bulkrax output:

Screen Shot 2022-11-18 at 3.19.52 PM.png

Desired output in both cases is that title or fileset_label be "Page 1" while the filename itself is *0.tif etc. The filenames themselves are correct.

@eporter23
Copy link
Contributor Author

OK, I just fact checked myself and while there are no filesets titled "Page 0" in SOLR, we must have been cleaning these up manually after the fact. I ran the preprocessors in prod and they do the same thing. We can flag this as an enhancement and nothing urgent. Sorry for the confusion @bwatson78 and @kmichaelis .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant