Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[diskette_dump] Save dump created from commandline as a DumpFile object #18

Closed
sveetch opened this issue Dec 2, 2024 · 2 comments
Closed
Labels
feature For new feature development

Comments

@sveetch
Copy link
Member

sveetch commented Dec 2, 2024

Is your feature request related to a problem? Please describe.

Currently, creating a dump from commandline diskette_dump does not create any DumpFile entry, it justs create the dump that won't be retrieved from the admin and so:

  • Dump file can not be retrieved from admin and so can't be purged;
  • Dump file can not be downloaded from admin;

Describe the solution you'd like

We should add an argument --save to the commandline. When used it will create a proper DumpFile for the created dump archive. This should be done once after the dump has been well created, the DumpFile will be directly made with status "processed".

It should also perform the deprecation and purge processes but obviously not the admin dump process.

@sveetch sveetch added the feature For new feature development label Dec 2, 2024
@sveetch
Copy link
Member Author

sveetch commented Feb 2, 2025

Since we introduced a setting to disable admin, this option should not work when admin is disabled, else it may create many object in database without a way to manage them and remove them.

@sveetch
Copy link
Member Author

sveetch commented Feb 2, 2025

Done in v0.5.0-pre.5

@sveetch sveetch closed this as completed Feb 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature For new feature development
Projects
None yet
Development

No branches or pull requests

1 participant