Skip to content

Commit 4720360

Browse files
authored
Merge pull request #912 from bertdeblock/make-sure-focus-related-test-dont-fail-when-the-container-is-hidden
2 parents 27e7644 + ed643e1 commit 4720360

File tree

2 files changed

+11
-5
lines changed

2 files changed

+11
-5
lines changed

addon-test-support/index.js

+4-3
Original file line numberDiff line numberDiff line change
@@ -89,13 +89,14 @@ export function setupTestContainer() {
8989
}
9090

9191
let params = QUnit.urlParams;
92-
let containerVisibility = params.nocontainer ? 'hidden' : 'visible';
9392

9493
if (params.devmode || params.fullscreencontainer) {
95-
testContainer.className = ' full-screen';
94+
testContainer.classList.add('ember-testing-container-full-screen');
9695
}
9796

98-
testContainer.style.visibility = containerVisibility;
97+
if (params.nocontainer) {
98+
testContainer.classList.add('ember-testing-container-hidden');
99+
}
99100
}
100101

101102
/**

vendor/ember-qunit/test-container-styles.css

+7-2
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@
3030
transform: translateZ(0);
3131
}
3232

33-
#ember-testing-container.full-screen {
33+
#ember-testing-container.ember-testing-container-full-screen {
3434
width: 100%;
3535
height: 100%;
3636
overflow: auto;
@@ -39,14 +39,19 @@
3939
right: 0;
4040
}
4141

42+
#ember-testing-container.ember-testing-container-hidden {
43+
opacity: 0;
44+
pointer-events: none;
45+
}
46+
4247
#ember-testing {
4348
width: 200%;
4449
height: 200%;
4550
transform: scale(0.5);
4651
transform-origin: top left;
4752
}
4853

49-
.full-screen #ember-testing {
54+
.ember-testing-container-full-screen #ember-testing {
5055
position: absolute;
5156
width: 100%;
5257
height: 100%;

0 commit comments

Comments
 (0)