From 4492b542c8b197b4cfea4d7fc1af47db969056ff Mon Sep 17 00:00:00 2001
From: Melanie Sumner <melanie@hashicorp.com>
Date: Tue, 14 Apr 2026 14:46:31 -0500
Subject: [PATCH 1/2] Removed invalid code in form labels rule

Update a11y-form-labels.md

Prettier fix
---
 skills/ember-best-practices/rules/a11y-form-labels.md | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/skills/ember-best-practices/rules/a11y-form-labels.md b/skills/ember-best-practices/rules/a11y-form-labels.md
index c7b4eae9..1186b7d1 100644
--- a/skills/ember-best-practices/rules/a11y-form-labels.md
+++ b/skills/ember-best-practices/rules/a11y-form-labels.md
@@ -35,9 +35,7 @@ All form inputs must have associated labels, and validation errors should be ann
     <div>
       <label for="email-input">
         Email Address
-        {{#if this.isEmailRequired}}
-          <span aria-label="required">*</span>
-        {{/if}}
+        <span aria-hidden="true">*</span>
       </label>
 
       <input

From c6f79b701fc1bc01e20c939a42527073e49d6824 Mon Sep 17 00:00:00 2001
From: Melanie Sumner <melanie@hashicorp.com>
Date: Tue, 14 Apr 2026 16:33:27 -0500
Subject: [PATCH 2/2] Add build/validate results

---
 packages/ember-best-practices-build/test-cases.json | 2 +-
 skills/ember-best-practices/AGENTS.md               | 4 +---
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/packages/ember-best-practices-build/test-cases.json b/packages/ember-best-practices-build/test-cases.json
index e5edf1ae..db17f41f 100644
--- a/packages/ember-best-practices-build/test-cases.json
+++ b/packages/ember-best-practices-build/test-cases.json
@@ -27,7 +27,7 @@
     "ruleId": "",
     "ruleTitle": "Form Labels and Error Announcements",
     "type": "good",
-    "code": "// app/components/form.gjs\n<template>\n  <form {{on \"submit\" this.handleSubmit}}>\n    <div>\n      <label for=\"email-input\">\n        Email Address\n        {{#if this.isEmailRequired}}\n          <span aria-label=\"required\">*</span>\n        {{/if}}\n      </label>\n\n      <input\n        id=\"email-input\"\n        type=\"email\"\n        value={{this.email}}\n        {{on \"input\" this.updateEmail}}\n        aria-describedby={{if this.emailError \"email-error\"}}\n        aria-invalid={{if this.emailError \"true\"}}\n        required={{this.isEmailRequired}}\n      />\n\n      {{#if this.emailError}}\n        <span id=\"email-error\" role=\"alert\" aria-live=\"polite\">\n          {{this.emailError}}\n        </span>\n      {{/if}}\n    </div>\n\n    <button type=\"submit\" disabled={{this.isSubmitting}}>\n      {{#if this.isSubmitting}}\n        <span aria-live=\"polite\">Submitting...</span>\n      {{else}}\n        Submit\n      {{/if}}\n    </button>\n  </form>\n</template>",
+    "code": "// app/components/form.gjs\n<template>\n  <form {{on \"submit\" this.handleSubmit}}>\n    <div>\n      <label for=\"email-input\">\n        Email Address\n        <span aria-hidden=\"true\">*</span>\n      </label>\n\n      <input\n        id=\"email-input\"\n        type=\"email\"\n        value={{this.email}}\n        {{on \"input\" this.updateEmail}}\n        aria-describedby={{if this.emailError \"email-error\"}}\n        aria-invalid={{if this.emailError \"true\"}}\n        required={{this.isEmailRequired}}\n      />\n\n      {{#if this.emailError}}\n        <span id=\"email-error\" role=\"alert\" aria-live=\"polite\">\n          {{this.emailError}}\n        </span>\n      {{/if}}\n    </div>\n\n    <button type=\"submit\" disabled={{this.isSubmitting}}>\n      {{#if this.isSubmitting}}\n        <span aria-live=\"polite\">Submitting...</span>\n      {{else}}\n        Submit\n      {{/if}}\n    </button>\n  </form>\n</template>",
     "language": "glimmer-js",
     "description": "with labels and announcements"
   },
diff --git a/skills/ember-best-practices/AGENTS.md b/skills/ember-best-practices/AGENTS.md
index 7895aed7..eea74440 100644
--- a/skills/ember-best-practices/AGENTS.md
+++ b/skills/ember-best-practices/AGENTS.md
@@ -3441,9 +3441,7 @@ All form inputs must have associated labels, and validation errors should be ann
     <div>
       <label for="email-input">
         Email Address
-        {{#if this.isEmailRequired}}
-          <span aria-label="required">*</span>
-        {{/if}}
+        <span aria-hidden="true">*</span>
       </label>
 
       <input