From 73524e440f1b3e6df6c6f062cf68d86fcc757783 Mon Sep 17 00:00:00 2001 From: Rajasegar Date: Tue, 18 Jun 2019 16:21:17 +0530 Subject: [PATCH 1/2] [DOCS] Update 3rd party code example with dependencies Fixes #105 --- markdown/docs/addon-author-guide.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/markdown/docs/addon-author-guide.md b/markdown/docs/addon-author-guide.md index 9b3e331..f0f4922 100644 --- a/markdown/docs/addon-author-guide.md +++ b/markdown/docs/addon-author-guide.md @@ -197,6 +197,8 @@ Node compatible, you can wrap it with a check as below in an addon: ```js var map = require('broccoli-stew').map; +var Funnel = require('broccoli-funnel'); +var mergeTrees = require('broccoli-merge-trees'); treeForVendor(defaultTree) { var browserVendorLib = new Funnel(); From 956f31ba90914a128355ae8b97152ac2d4dad1a0 Mon Sep 17 00:00:00 2001 From: Rajasegar Chandran Date: Tue, 18 Jun 2019 17:02:42 +0530 Subject: [PATCH 2/2] [DOCS] Adding missing app param Including the app parameter for included hook --- markdown/docs/addon-author-guide.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/markdown/docs/addon-author-guide.md b/markdown/docs/addon-author-guide.md index f0f4922..25983de 100644 --- a/markdown/docs/addon-author-guide.md +++ b/markdown/docs/addon-author-guide.md @@ -208,7 +208,7 @@ treeForVendor(defaultTree) { return new mergeTrees([defaultTree, browserVendorLib]); } -included() { +included(app) { // this file will be loaded in FastBoot but will not be eval'd app.import('vendor/.js'); }