Duplicated log messages with omnisharp

[hpfr]

@razzmatazz I was told you're the C# goto in the Discord. In *lsp-log*, most messages seem to be duplicated. Here's a snippet:

Found the following clients for /snip.cs: (server-id csharp, priority 0)
The following clients were selected based on priority: (server-id csharp, priority 0)
OmniSharp.Services.DotNetCliService: DotNetPath set to dotnet | 
OmniSharp.Services.DotNetCliService: DotNetPath set to dotnet | 
OmniSharp.MSBuild.Discovery.MSBuildLocator: Located 1 MSBuild instance(s)
            1: StandAlone 16.10.1 - "/nix/store/hga6hv6jdppmii48gdw1hb34gfvvi8wi-omnisharp-roslyn-1.37.12/src/.msbuild/Current/Bin" | 
OmniSharp.MSBuild.Discovery.MSBuildLocator: Located 1 MSBuild instance(s)
            1: StandAlone 16.10.1 - "/nix/store/hga6hv6jdppmii48gdw1hb34gfvvi8wi-omnisharp-roslyn-1.37.12/src/.msbuild/Current/Bin" | 
OmniSharp.MSBuild.Discovery.MSBuildLocator: MSBUILD_EXE_PATH environment variable set to '/nix/store/hga6hv6jdppmii48gdw1hb34gfvvi8wi-omnisharp-roslyn-1.37.12/src/.msbuild/Current/Bin/MSBuild.dll' | 
OmniSharp.MSBuild.Discovery.MSBuildLocator: MSBUILD_EXE_PATH environment variable set to '/nix/store/hga6hv6jdppmii48gdw1hb34gfvvi8wi-omnisharp-roslyn-1.37.12/src/.msbuild/Current/Bin/MSBuild.dll' | 
OmniSharp.MSBuild.Discovery.MSBuildLocator: Registered MSBuild instance: StandAlone 16.10.1 - "/nix/store/hga6hv6jdppmii48gdw1hb34gfvvi8wi-omnisharp-roslyn-1.37.12/src/.msbuild/Current/Bin"
            CscToolExe = csc.exe
            MSBuildToolsPath = /nix/store/hga6hv6jdppmii48gdw1hb34gfvvi8wi-omnisharp-roslyn-1.37.12/src/.msbuild/Current/Bin
            CscToolPath = /nix/store/hga6hv6jdppmii48gdw1hb34gfvvi8wi-omnisharp-roslyn-1.37.12/src/.msbuild/Current/Bin/Roslyn
            BypassFrameworkInstallChecks = true
            MSBuildExtensionsPath = /nix/store/hga6hv6jdppmii48gdw1hb34gfvvi8wi-omnisharp-roslyn-1.37.12/src/.msbuild | 
OmniSharp.MSBuild.Discovery.MSBuildLocator: Registered MSBuild instance: StandAlone 16.10.1 - "/nix/store/hga6hv6jdppmii48gdw1hb34gfvvi8wi-omnisharp-roslyn-1.37.12/src/.msbuild/Current/Bin"
            CscToolExe = csc.exe
            MSBuildToolsPath = /nix/store/hga6hv6jdppmii48gdw1hb34gfvvi8wi-omnisharp-roslyn-1.37.12/src/.msbuild/Current/Bin
            CscToolPath = /nix/store/hga6hv6jdppmii48gdw1hb34gfvvi8wi-omnisharp-roslyn-1.37.12/src/.msbuild/Current/Bin/Roslyn
            BypassFrameworkInstallChecks = true
            MSBuildExtensionsPath = /nix/store/hga6hv6jdppmii48gdw1hb34gfvvi8wi-omnisharp-roslyn-1.37.12/src/.msbuild | 
OmniSharp.WorkspaceInitializer: Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.CSharpFormattingWorkspaceOptionsProvider, Order: 0 | 
OmniSharp.WorkspaceInitializer: Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.CSharpFormattingWorkspaceOptionsProvider, Order: 0 | 
OmniSharp.WorkspaceInitializer: Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.Completion.CompletionOptionsProvider, Order: 0 | 
OmniSharp.WorkspaceInitializer: Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.Completion.CompletionOptionsProvider, Order: 0 | 
OmniSharp.WorkspaceInitializer: Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.RenameWorkspaceOptionsProvider, Order: 100 | 
OmniSharp.WorkspaceInitializer: Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.RenameWorkspaceOptionsProvider, Order: 100 | 
OmniSharp.WorkspaceInitializer: Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.ImplementTypeWorkspaceOptionsProvider, Order: 110 | 
OmniSharp.WorkspaceInitializer: Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.ImplementTypeWorkspaceOptionsProvider, Order: 110 | 
OmniSharp.WorkspaceInitializer: Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.BlockStructureWorkspaceOptionsProvider, Order: 140 | 
OmniSharp.WorkspaceInitializer: Invoking Workspace Options Provider: OmniSharp.Roslyn.CSharp.Services.BlockStructureWorkspaceOptionsProvider, Order: 140 | 
OmniSharp.Cake.CakeProjectSystem: Detecting Cake files in '/snip/src'. | 
OmniSharp.Cake.CakeProjectSystem: Detecting Cake files in '/snip/src'. | 
OmniSharp.Cake.CakeProjectSystem: Could not find any Cake files | 
OmniSharp.Cake.CakeProjectSystem: Could not find any Cake files | 
OmniSharp.MSBuild.ProjectSystem: Detecting projects in '/snip.sln'. | 
OmniSharp.MSBuild.ProjectSystem: Detecting projects in '/snip.sln'. | 

Does that look right? Things seem to be functioning properly, fortunately. I was just curious.

[razzmatazz]

Hi @hpfr

Right.. didn't notice this myself, but I can confirm this happens for the relatest release and for server built from the source.. let me check, if I can figure out an easy patch for this.. The actual related code is in https://github.com/OmniSharp/omnisharp-roslyn repo, but lately it has been hard for my PRs to be merged in for some reason so.. will try to take a look anyway

Shameful plug:

• Btw, I am trying to make my own LSP server (https://github.com/razzmatazz/csharp-language-server/tree/fsac-rebase) which would not have that big of contribution barrier :)

[razzmatazz]

I have created a PR to hopefully fix this:

• LSP: fix duplicate log messages OmniSharp/omnisharp-roslyn#2204

But I am not 100% sure that is the right approach, maybe @yatli will confirm