Skip to content

Commit 9aa6fe0

Browse files
committed
Check safe for test run on buffers
1 parent 0352b2e commit 9aa6fe0

File tree

1 file changed

+15
-14
lines changed

1 file changed

+15
-14
lines changed

lsp-dart.el

Lines changed: 15 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -390,7 +390,6 @@ otherwise the dart command."
390390

391391
(defun lsp-dart--build-test-name (names)
392392
"Build the test name from a group of test NAMES."
393-
(message "%s" (json-encode names))
394393
(when (and names
395394
(not (seq-empty-p names)))
396395
(->> names
@@ -503,24 +502,26 @@ PARAMS is the notification data from outline."
503502
Run test of the overlay which has the smallest range of
504503
all test overlays in the current buffer."
505504
(interactive)
506-
(--> (overlays-in (point-min) (point-max))
507-
(--filter (when (overlay-get it 'lsp-dart-test-code-lens)
508-
(-let* (((beg . end) (overlay-get it 'lsp-dart-test-overlay-test-range)))
509-
(and (>= (point) beg)
510-
(<= (point) end)))) it)
511-
(--min-by (-let* (((beg1 . end1) (overlay-get it 'lsp-dart-test-overlay-test-range))
512-
((beg2 . end2) (overlay-get other 'lsp-dart-test-overlay-test-range)))
513-
(and (< beg1 beg2)
514-
(> end1 end2))) it)
515-
(lsp-dart--run-test (current-buffer)
516-
(overlay-get it 'lsp-dart-test-names)
517-
(overlay-get it 'lsp-dart-test-kind))))
505+
(-some--> (overlays-in (point-min) (point-max))
506+
(--filter (when (overlay-get it 'lsp-dart-test-code-lens)
507+
(-let* (((beg . end) (overlay-get it 'lsp-dart-test-overlay-test-range)))
508+
(and (>= (point) beg)
509+
(<= (point) end)))) it)
510+
(--min-by (-let* (((beg1 . end1) (overlay-get it 'lsp-dart-test-overlay-test-range))
511+
((beg2 . end2) (overlay-get other 'lsp-dart-test-overlay-test-range)))
512+
(and (< beg1 beg2)
513+
(> end1 end2))) it)
514+
(lsp-dart--run-test (current-buffer)
515+
(overlay-get it 'lsp-dart-test-names)
516+
(overlay-get it 'lsp-dart-test-kind))))
518517

519518
;;;###autoload
520519
(defun lsp-dart-run-test-file ()
521520
"Run dart/Flutter test command only for current buffer."
522521
(interactive)
523-
(lsp-dart--run-test (current-buffer)))
522+
(if (lsp-dart-test-file-p (buffer-file-name))
523+
(lsp-dart--run-test (current-buffer))
524+
(user-error "Current buffer is not a Dart/Flutter test file")))
524525

525526

526527
;;;###autoload(with-eval-after-load 'lsp-mode (require 'lsp-dart))

0 commit comments

Comments
 (0)