sucrose: context pass to function with sub context

[Riant]

What version of Elysia is running?

1.4.16

What platform is your computer?

Windows 10

What environment are you using

bun 1.2.19

Are you using dynamic mode?

NO

What steps can reproduce the bug?

return new Elysia().get('/test', (context) => {
    console.log('path >>> ', context.path)
    test2(context)
    return {id: 'test'}
  })
  function test2(context) {
    console.log('test2 >>> ', context.query)
  }

如上所示，此时访问 /test?id=1，test2 中的输出会是 undefined，但是当我们将console.log('path >>> ', context.path) 行注释掉之后，test2 中的输出就正常了。

What is the expected behavior?

函数 test2 中应该能够正常访问 context.query

What do you see instead?

函数test2 输出了 test2 >>> undefined

Additional information

即使我们将调用 test2 之后的 return 语句改为return {path: context.path}, test2 中也会取不到 context.query

Have you try removing the node_modules and bun.lockb and try again yet?

NO

[Niapya]

我认为这是预期行为。因为 ElysiaJS 并不知道你在外部要用到 context.query，因为由于 JIT 优化了这部分代码，所以你不能在在外部获取到 context.query ，你可以阅读 https://saltyaom.com/blog/elysia-sucrose/ 来了解到背后的设计思路，你可以参考官方实践来修改你的代码。

new Elysia().get("/test", ({path, query}) => {
	console.log("path >>> ", path);
	test2(query);
	return { id: "test" };
});
function test2(query) {
	console.log("test2 >>> ", query);
}

另外我建议你在社区使用英文，不然有些人很费解。
Additionally, I recommend using English in the community, otherwise some people might find it confusing.

[Riant]

But if we remove the context.path line like below, it will woks well:

return new Elysia().get('/test', (context) => {
    test2(context)
    return {id: 'test'}
  })
  function test2(context) {
    console.log('test2 >>> ', context.query)
  }

[Niapya]

Alright, this might actually be a bug.

The isContextPassToFunction function in sucrose.ts (lines 547-592) detected your context.path and returned false. This caused it to skip checking whether the context was passed to the test2 function.

if (!isContextPassToFunction(mainParameter, code, fnInference))
                inferBodyReference(code, aliases, fnInference)

Additionally, passing the entire context like this is not really in line with best practices, significantly sacrificing Elysia's performance.I recommend against using it in actual production.

[SaltyAom]

Fixed by 620d96b. Will be published under 1.4.19 (#1610).

To test locally, use the patch version

bun add https://pkg.pr.new/elysiajs/elysia@1610