-
Notifications
You must be signed in to change notification settings - Fork 53
Refactor to functional component #2781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Refactor to functional component #2781
Conversation
Signed-off-by: Amritha raj herle <[email protected]>
Signed-off-by: Amritha raj herle <[email protected]>
530dbed to
a03d4c9
Compare
Signed-off-by: Amritha raj herle <[email protected]>
a03d4c9 to
99d2a62
Compare
| @@ -0,0 +1,15 @@ | |||
| { | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please delete this file.
|
|
||
| getConfig() { | ||
| const config = Object.assign({}, this.props.config, { | ||
| const propertiesRef = React.createRef(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use const propertiesRef = React.useRef(null); here
|
|
||
|
|
||
| useEffect(() => { | ||
| const setNodeSize = () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add all the comments which were present in this file.
| componentDidMount() { | ||
| this.setNodeSize(); | ||
| } | ||
| const divRef = React.createRef(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use const divRef = React.useRef(null); here
nmgokhale
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing! Added some review comments.
Fixes: #2774
Developer's Certificate of Origin 1.1