Skip to content

Conversation

@herleraja
Copy link

Fixes: #2774

Developer's Certificate of Origin 1.1

   By making a contribution to this project, I certify that:

   (a) The contribution was created in whole or in part by me and I
       have the right to submit it under the Apache License 2.0; or

   (b) The contribution is based upon previous work that, to the best
       of my knowledge, is covered under an appropriate open source
       license and I have the right under that license to submit that
       work with modifications, whether created in whole or in part
       by me, under the same open source license (unless I am
       permitted to submit under a different license), as indicated
       in the file; or

   (c) The contribution was provided directly to me by some other
       person who certified (a), (b) or (c) and I have not modified
       it.

   (d) I understand and agree that this project and the contribution
       are public and that a record of the contribution (including all
       personal information I submit with it, including my sign-off) is
       maintained indefinitely and may be redistributed consistent with
       this project or the open source license(s) involved.

@herleraja herleraja force-pushed the refactor-to-functional-component branch from 530dbed to a03d4c9 Compare October 27, 2025 08:40
@herleraja herleraja force-pushed the refactor-to-functional-component branch from a03d4c9 to 99d2a62 Compare October 27, 2025 08:52
@tomlyn tomlyn requested review from nmgokhale and tomlyn October 30, 2025 04:40
@@ -0,0 +1,15 @@
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete this file.


getConfig() {
const config = Object.assign({}, this.props.config, {
const propertiesRef = React.createRef();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use const propertiesRef = React.useRef(null); here



useEffect(() => {
const setNodeSize = () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add all the comments which were present in this file.

componentDidMount() {
this.setNodeSize();
}
const divRef = React.createRef();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use const divRef = React.useRef(null); here

Copy link
Member

@nmgokhale nmgokhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing! Added some review comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Covert some of the sample apps in the test harness to use React functional components

2 participants