elm publish does not require the bumped elm.json to be pushed to GitHub

[billstclair]

My process for publishing a new version of a package is as follows (in Elm 0.19):

1. Make changes and test them
2. elm bump
3. git commit -am "Bump version from xxx to yyy"; git push
4. elm publish
5. Execute the two lines printed about updating the tags on GitHub (I have an Emacs keyboard macro that copies one of those lines down in my shell buffer).
6. elm publish

Sometimes I combine the last changes with the elm bump in a single commit.

This is all well and good, except sometimes I forgot to git push the elm.json with the bumped version number (in step 3). elm publish does not complain, and I end up with a new tag on GitHub with an elm.json containing the previous version number.

This doesn't appear to cause any real problems, but it's annoying. elm publish should error if the elm.json on GitHub doesn't match the local copy.

[genthaler]

Somewhat related, I forgot to git add the new elm.json before committing along with other changes, so again elm.json didn't end up on GitHub.

[RalfNorthman]

As I understand it you don't have to push any changes to github to publish your local changes.

I have experience of upgrading a package to 0.19, just to find out that the owner had already done it - and published, but had not pushed to github.

It was not a ton of work, so it's not a big deal that way. I'm just surprised something like that was even possible.