Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with CCSE on web version #1

Open
obj-obj opened this issue Oct 22, 2023 · 6 comments
Open

Incompatible with CCSE on web version #1

obj-obj opened this issue Oct 22, 2023 · 6 comments
Assignees
Labels
bug Something isn't working

Comments

@obj-obj
Copy link

obj-obj commented Oct 22, 2023

The options menu is blank and opening it will freeze the game if this mod is used with CCSE

@elliotks
Copy link
Owner

elliotks commented Nov 8, 2023

The options menu is blank and opening it will freeze the game if this mod is used with CCSE

Hi @obj-obj would you please provide more information on your setup including so I can replicate it on my end? Does this only effect the web version? Or steam version as well.

Sorry for the late reply - for whatever reason I did not see a notification.

@elliotks elliotks self-assigned this Nov 8, 2023
@elliotks elliotks added the bug Something isn't working label Nov 8, 2023
@obj-obj
Copy link
Author

obj-obj commented Nov 9, 2023

The options menu is blank and opening it will freeze the game if this mod is used with CCSE

Hi @obj-obj would you please provide more information on your setup including so I can replicate it on my end? Does this only effect the web version? Or steam version as well.

Sorry for the late reply - for whatever reason I did not see a notification.

I don't have the game on steam, so I can't test that. You should be able to use one of the mod manager extensions (like this one) and install both mods to reproduce the issue.

@elliotks
Copy link
Owner

elliotks commented Nov 9, 2023

The options menu is blank and opening it will freeze the game if this mod is used with CCSE

Hi @obj-obj would you please provide more information on your setup including so I can replicate it on my end? Does this only effect the web version? Or steam version as well.
Sorry for the late reply - for whatever reason I did not see a notification.

I don't have the game on steam, so I can't test that. You should be able to use one of the mod manager extensions (like this one) and install both mods to reproduce the issue.

Thanks @obj-obj I will review this later today.

@elliotks
Copy link
Owner

Hi @obj-obj I installed Firefox and installed the mod manager extension https://addons.mozilla.org/en-US/firefox/addon/yaccmm/
I then added
ACABM - https://cdn.jsdelivr.net/gh/elliotks/ACABM/autoclickandbuyMod/main.js
Cookie Monster - https://cookiemonsterteam.github.io/CookieMonster/dist/CookieMonster.js

I did notice after adding Cookie Monster my web browser performance tanked. In the console logs many "[Violation] 'setTimeout' handler took 100+ms" type messages come up while both are enabled at the same time.

I will need more time to review this, and see if it is even possible to resolve.

Thanks,

@sigboe
Copy link

sigboe commented Feb 8, 2024

I can also reproduce this in Firefox, when Auto Click And Buy is loaded, either before or after CCSE is loaded, when opening the settings panel Cookie clicker hangs. In the Steam version things work.

@elliotks
Copy link
Owner

Hello @obj-obj and @sigboe
I have refactored the Controller and changed the way intervals and timeouts are handled - basically hooking into Cookie Clicker's logic modHook. So far it seems to resolve the issues with CookieMonster and ACABM being active together.

Please let me know how it works on the web version, I have not updated the Steam version yet since I am still testing for issues from the refactor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants