Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin abstract: test config and test configuration #2620

Open
ai16z-demirix opened this issue Jan 21, 2025 · 0 comments
Open

plugin abstract: test config and test configuration #2620

ai16z-demirix opened this issue Jan 21, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@ai16z-demirix
Copy link
Contributor

Is your feature request related to a problem? Please describe.

The plugin-abstract package currently lacks test coverage for critical token operations. Without proper test coverage for getBalanceAction and transferAction, we risk:

Undetected bugs in balance checking functionality
Potential issues with token transfers
No validation of AGW integration
Missing edge case handling
Unreliable error handling for failed operations

This makes the codebase less maintainable and increases the risk of introducing bugs when making changes.

Describe the solution you'd like

We need comprehensive test coverage for all three actions that includes:

For deployTokenAction:

  • Tests for token deployment parameters (name, symbol, supply)
  • Validation of abstract configuration
  • Testing both AGW and non-AGW deployments
  • Error handling for invalid inputs
  • Testing state management
  • Coverage for deployment transaction failures
    For getBalanceAction:
  • Tests for checking ETH balances
  • Tests for checking ERC20 token balances
  • Validation of token symbols and addresses
  • Error handling for invalid inputs
  • Testing state management
    For transferAction:
  • Tests for ETH transfers
  • Tests for ERC20 token transfers
  • Testing AGW integration
  • Validation of inputs
  • Error case coverage

Describe alternatives you've considered

Additional context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant