Skip to content

Commit 1030083

Browse files
committed
wip fix socket mismatch between selected and succeeded pairs
1 parent 7552d06 commit 1030083

File tree

1 file changed

+11
-2
lines changed

1 file changed

+11
-2
lines changed

lib/ex_ice/priv/ice_agent.ex

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2014,6 +2014,11 @@ defmodule ExICE.Priv.ICEAgent do
20142014
valid?: true
20152015
}
20162016

2017+
checklist_local_cand = Map.fetch!(ice_agent.local_cands, checklist_pair.local_cand_id)
2018+
checklist_local_cand = put_in(checklist_local_cand.base.closed?, true)
2019+
2020+
ice_agent = put_in(ice_agent.local_cands[checklist_local_cand.base.id], checklist_local_cand)
2021+
20172022
checklist =
20182023
ice_agent.checklist
20192024
|> Map.replace!(conn_check_pair.id, conn_check_pair)
@@ -2617,10 +2622,14 @@ defmodule ExICE.Priv.ICEAgent do
26172622
sel_local_cand = Map.fetch!(ice_agent.local_cands, selected_pair.local_cand_id)
26182623

26192624
if succ_local_cand.base.socket != sel_local_cand.base.socket do
2620-
raise """
2625+
# raise """
2626+
# Selected local candidate's socket is different than succeeded local candidate's socket. \
2627+
# This should never happen as we check against symmetric response.\
2628+
# """
2629+
Logger.error("""
26212630
Selected local candidate's socket is different than succeeded local candidate's socket. \
26222631
This should never happen as we check against symmetric response.\
2623-
"""
2632+
""")
26242633
end
26252634

26262635
ice_agent =

0 commit comments

Comments
 (0)